Skip to content

Adding language EOL warning log #11253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Adding language EOL warning log #11253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fcbb3e
language EOL warning log
hallvictoria Aug 14, 2025
4a34af9
change to string
hallvictoria Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/WebJobs.Script/Workers/Rpc/RpcWorkerDescription.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@ public class RpcWorkerDescription : WorkerDescription
[JsonProperty(PropertyName = "supportedRuntimeVersions")]
public List<string> SupportedRuntimeVersions { get; set; }

/// <summary>
/// Gets the minimum supported versions for this runtime.
/// </summary>
[JsonProperty(PropertyName = "minimumSupportedRuntimeVersion")]
public string MinimumSupportedRuntimeVersion { get; }

/// <summary>
/// Gets or sets the regex used for sanitizing the runtime version string.
/// </summary>
Expand Down Expand Up @@ -202,6 +208,22 @@ internal void FormatWorkerPathIfNeeded(ISystemRuntimeInformation systemRuntimeIn
DefaultRuntimeVersion = GetSanitizedRuntimeVersion(version);
}

if (!string.IsNullOrEmpty(MinimumSupportedRuntimeVersion) && !string.IsNullOrEmpty(DefaultRuntimeVersion))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I /think/ DefaultRuntimeVersion now holds the updated language version that's being used instead of version, but if that's incorrect please lmk!

{
if (Version.TryParse(DefaultRuntimeVersion, out var currentVersion) &&
Version.TryParse(MinimumSupportedRuntimeVersion, out var minVersion))
{
if (currentVersion < minVersion)
{
logger.LogWarning($"The configured runtime version '{DefaultRuntimeVersion}' for language '{Language}' is lower than the minimum supported version '{MinimumSupportedRuntimeVersion}'. Please update to a supported version. Visit aka.ms/supported-language-versions for more information.");
}
}
else
{
logger.LogWarning($"Could not parse runtime version(s): '{DefaultRuntimeVersion}' or '{MinimumSupportedRuntimeVersion}' for language '{Language}'.");
}
}

ValidateDefaultWorkerPathFormatters(systemRuntimeInformation);

DefaultWorkerPath = DefaultWorkerPath.Replace(RpcWorkerConstants.OSPlaceholder, os.ToString())
Expand Down