Skip to content

Conversation

RohitRanjanMS
Copy link
Member

@RohitRanjanMS RohitRanjanMS commented Aug 21, 2025

  • Replaced deprecated RecordException with AddException.
  • Added support for implementationFactory in ServiceMatch to handle AzMon exporter live metrics service registration.
  • Updated to new UseOtlpExporter() and UseAzureMonitorExporter() APIs — now auto‑configures trace, metrics, logging, and log streaming.
  • Reduced telemetry noise by:
  • Using targeted source names instead of wildcard Azure.*.
  • Filtering out localhost‑originated request telemetry.
  • Removed obsolete reflection‑based tests that no longer work with newer package versions.

resolves #10666

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@RohitRanjanMS RohitRanjanMS marked this pull request as ready for review August 21, 2025 21:30
@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 21:30
@RohitRanjanMS RohitRanjanMS requested a review from a team as a code owner August 21, 2025 21:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the OpenTelemetry configuration to modernize APIs, reduce telemetry noise, and improve reliability by replacing deprecated methods and removing brittle reflection-based tests.

  • Replaced deprecated RecordException with AddException for activity exception logging
  • Updated to new UseOtlpExporter() and UseAzureMonitorExporter() APIs that auto-configure all telemetry types
  • Reduced telemetry noise by using targeted Azure source names and filtering localhost requests

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
OpenTelemetryConfigurationExtensions.cs Updated to new exporter APIs, restructured configuration methods, added localhost filtering
ServiceMatch.cs Added support for implementationFactory in service matching logic
DependencyValidator.cs Updated external service registrations for new telemetry services
GrpcWorkerChannel.cs Replaced deprecated RecordException with AddException
OpenTelemetryConfigurationExtensionsTests.cs Removed reflection-based tests and simplified test configuration
release_notes.md Added entry for telemetry refactoring changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@RohitRanjanMS RohitRanjanMS marked this pull request as draft August 21, 2025 21:42
@RohitRanjanMS RohitRanjanMS marked this pull request as ready for review August 22, 2025 05:33
Copy link
Member

@brettsam brettsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small api comment

@RohitRanjanMS RohitRanjanMS merged commit 70571a9 into dev Aug 28, 2025
9 checks passed
@RohitRanjanMS RohitRanjanMS deleted the roranjan/otel-streaming branch August 28, 2025 18:15
RohitRanjanMS added a commit that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Streaming on Azure Portal
4 participants