-
Notifications
You must be signed in to change notification settings - Fork 466
Refactor telemetry & exporter setup: deprecations, noise reduction, and API updates #11260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the OpenTelemetry configuration to modernize APIs, reduce telemetry noise, and improve reliability by replacing deprecated methods and removing brittle reflection-based tests.
- Replaced deprecated
RecordException
withAddException
for activity exception logging - Updated to new
UseOtlpExporter()
andUseAzureMonitorExporter()
APIs that auto-configure all telemetry types - Reduced telemetry noise by using targeted Azure source names and filtering localhost requests
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
OpenTelemetryConfigurationExtensions.cs | Updated to new exporter APIs, restructured configuration methods, added localhost filtering |
ServiceMatch.cs | Added support for implementationFactory in service matching logic |
DependencyValidator.cs | Updated external service registrations for new telemetry services |
GrpcWorkerChannel.cs | Replaced deprecated RecordException with AddException |
OpenTelemetryConfigurationExtensionsTests.cs | Removed reflection-based tests and simplified test configuration |
release_notes.md | Added entry for telemetry refactoring changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/WebJobs.Script.WebHost/DependencyInjection/DependencyValidator/ServiceMatch.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/DependencyInjection/DependencyValidator/ServiceMatch.cs
Show resolved
Hide resolved
src/WebJobs.Script/Diagnostics/OpenTelemetry/OpenTelemetryConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small api comment
src/WebJobs.Script.WebHost/DependencyInjection/DependencyValidator/ServiceMatch.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script.WebHost/DependencyInjection/DependencyValidator/ServiceMatch.cs
Show resolved
Hide resolved
src/WebJobs.Script/Diagnostics/OpenTelemetry/OpenTelemetryConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/Diagnostics/OpenTelemetry/OpenTelemetryConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
.../WebJobs.Script.Tests/Diagnostics/OpenTelemetry/OpenTelemetryConfigurationExtensionsTests.cs
Show resolved
Hide resolved
…ure-functions-host into roranjan/otel-streaming
resolves #10666
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md