-
Notifications
You must be signed in to change notification settings - Fork 4k
[PS] Migrate ScheduledQueryRule in Monitor module to autorest v4 #28195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
To the author of the pull request, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the ScheduledQueryRule module in Azure Monitor from AutoRest v3 to v4, representing a significant infrastructure upgrade for the PowerShell cmdlets that manage scheduled query rules in Azure Monitor.
- Updates test configurations to use fixed resources instead of dynamically created ones
- Migrates from AutoRest v3 to v4 generation framework
- Updates type system to use generic collection types instead of strongly typed arrays
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
tools/StaticAnalysis/Exceptions/Az.Monitor/BreakingChangeIssues.csv | Documents expected breaking changes for property types and parameter sets |
src/Monitor/ScheduledQueryRule.Autorest/test/*.ps1 | Updates test setup to use hardcoded resource names and IDs |
src/Monitor/ScheduledQueryRule.Autorest/test/env.json | Changes environment configuration to use specific test resources |
src/Monitor/ScheduledQueryRule.Autorest/docs/*.md | Updates parameter types and adds new parameter sets for JSON operations |
src/Monitor/ScheduledQueryRule.Autorest/custom/*.ps1 | Migrates custom cmdlets to new type system with string-based parameters |
src/Monitor/ScheduledQueryRule.Autorest/README.md | Simplifies AutoRest configuration and removes v3-specific directives |
src/Monitor/Monitor/help/*.md | Updates help documentation to reflect new parameter types |
src/Monitor/Monitor.sln | Adds duplicate project entries to solution file |
src/Monitor/Monitor.sln
Outdated
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "ScheduledQueryRule.Autorest", "ScheduledQueryRule.Autorest", "{DFE9A16E-4879-AFA3-BD8B-DBC73F42D0CA}" | ||
EndProject | ||
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Az.ScheduledQueryRule", "..\..\generated\Monitor\ScheduledQueryRule.Autorest\Az.ScheduledQueryRule.csproj", "{9E22CFC6-9848-4A63-ABED-225A7EE2BC77}" | ||
EndProject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate project entries are being added to the solution file. This creates redundant references that could cause build issues.
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "ScheduledQueryRule.Autorest", "ScheduledQueryRule.Autorest", "{DFE9A16E-4879-AFA3-BD8B-DBC73F42D0CA}" | |
EndProject | |
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Az.ScheduledQueryRule", "..\..\generated\Monitor\ScheduledQueryRule.Autorest\Az.ScheduledQueryRule.csproj", "{9E22CFC6-9848-4A63-ABED-225A7EE2BC77}" | |
EndProject |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.