Skip to content

[Az.ServiceFabric] Set-AzServiceFabricManagedNodeType: Add parameter -VmSize #28230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 22, 2025
Merged

[Az.ServiceFabric] Set-AzServiceFabricManagedNodeType: Add parameter -VmSize #28230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
31c6133
`Set-AzServiceFabricManagedNodeType`: Add parameter `VmSize` to allow…
iliu816 Jul 18, 2025
b310ad4
run generate help
iliu816 Jul 18, 2025
0e1c84f
update cluster tag for faster test run
iliu816 Jul 18, 2025
3e030af
Revert "run generate help"
iliu816 Jul 21, 2025
ad62458
update only Set-AzServiceFabricManagedNodeType.md
iliu816 Jul 21, 2025
e27681d
Update src/ServiceFabric/ServiceFabric/ChangeLog.md
YanaXu Jul 22, 2025
8f4d29e
Update src/ServiceFabric/ServiceFabric/ChangeLog.md
YanaXu Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ public void TestNodeTypeOperations()
TestRunner.RunTestScript("Test-NodeTypeOperations");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestNodeTypeVmSizeChange()
{
TestRunner.RunTestScript("Test-NodeTypeVmSizeChange");
}

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestCertAndExtension()
Expand Down
42 changes: 38 additions & 4 deletions src/ServiceFabric/ServiceFabric.Test/ScenarioTests/ServiceFabricManagedClustersTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ function Test-NodeTypeOperations
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-NodeTypeOperations"}
$clusterTags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.UseUnmonitoredAutoClusterUpgradePolicy"="True"; "testName"="Test-NodeTypeOperations"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -UpgradeMode Automatic -UpgradeCadence Wave1 -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $clusterTags -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
Expand Down Expand Up @@ -99,14 +99,48 @@ function Test-NodeTypeOperations
Assert-True { $removeResponse }
}

function Test-NodeTypeVmSizeChange
{
$resourceGroupName = "sfmcps-rg-" + (getAssetname)
$clusterName = "sfmcps-" + (getAssetname)
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.UseUnmonitoredAutoClusterUpgradePolicy"="True"; "testName"="Test-NodeTypeVmSizeChange"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

$cluster = New-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName -UpgradeMode Automatic -UpgradeCadence Wave1 -Location $location `
-AdminPassword $pass -Sku Standard -ClientCertThumbprint $testClientTp -Tag $tags -Verbose
Assert-AreEqual "Succeeded" $cluster.ProvisioningState
Assert-AreEqual "WaitingForNodes" $cluster.ClusterState
Assert-AreEqual "Automatic" $cluster.ClusterUpgradeMode
Assert-AreEqual "Wave1" $cluster.ClusterUpgradeCadence

New-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -InstanceCount 5 -Primary -DiskType Premium_LRS -VmSize Standard_DS2

$pnt = Get-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt
Assert-AreEqual "Premium_LRS" $pnt.DataDiskType
Assert-AreEqual "Standard_DS2" $pnt.VmSize

$swapSize = Set-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt -VmSize Standard_DS3_v2
Assert-True { $swapSize }

$pnt = Get-AzServiceFabricManagedNodeType -ResourceGroupName $resourceGroupName -ClusterName $clusterName -Name pnt
Assert-AreEqual "Premium_LRS" $pnt.DataDiskType
Assert-AreEqual "Standard_DS3_v2" $pnt.VmSize

$removeResponse = Remove-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -ClusterName $clusterName
}

function Test-CertAndExtension
{
$resourceGroupName = "sfmcps-rg-" + (getAssetname)
$clusterName = "sfmcps-" + (getAssetname)
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-CertAndExtension"}
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.UseUnmonitoredAutoClusterUpgradePolicy"="True"; "testName"="Test-CertAndExtension"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

Expand Down Expand Up @@ -157,7 +191,7 @@ function Test-AddNetworkSecurityRule
$pass = (ConvertTo-SecureString -AsPlainText -Force (-join ((33..126) | Get-Random -Count 16 | % {[char]$_})))
$location = "southcentralus"
$testClientTp = "123BDACDCDFB2C7B250192C6078E47D1E1DB119B"
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.WaitTimeBetweenUD"="00:00:10"; "testName"="Test-AddNetworkSecurityRule"}
$tags = @{"SFRP.EnableDiagnosticMI"="true"; "SFRP.DisableDefaultOutboundAccess"="true"; "SFRP.UseUnmonitoredAutoClusterUpgradePolicy"="True"; "testName"="Test-AddNetworkSecurityRule"}

Assert-ThrowsContains { Get-AzServiceFabricManagedCluster -ResourceGroupName $resourceGroupName -Name $clusterName } "NotFound"

Expand Down
Loading