Skip to content

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Sep 18, 2025

namespace was wrong

may need to follow up with a deprecation on computerecommender release branch

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Sep 18, 2025
@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review September 18, 2025 07:17
@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 07:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the compute recommender namespace from the Azure SDK for Java due to an incorrect namespace configuration. The removal involves deleting the entire sdk/computerecommender directory and updating related project configuration files.

  • Removes the entire compute recommender client library codebase
  • Updates project root POM to exclude the computerecommender module
  • Removes version tracking for the computerecommender artifact

Reviewed Changes

Copilot reviewed 50 out of 65 changed files in this pull request and generated no comments.

File Description
pom.xml Removes the computerecommender module from the project modules list
eng/versioning/version_client.txt Removes version tracking entry for azure-resourcemanager-computerecommender
sdk/computerecommender/* Complete removal of the compute recommender client library including source code, configuration files, and documentation

@weidongxu-microsoft weidongxu-microsoft merged commit dd9f3ab into Azure:main Sep 22, 2025
16 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_remove-computerecommender branch September 22, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants