-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Check both tenant and subscription before using shared Search resource #47188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check both tenant and subscription before using shared Search resource #47188
Conversation
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines the conditional logic for accessing static test resources in the Azure Search Bicep template. The change ensures that static resources are only used when both the tenant ID and subscription ID match specific values, providing more precise control over resource selection.
Key Changes
- Renamed variable from
isTmeTenanttocanUseStaticfor clarity - Enhanced condition to check both tenant ID and subscription ID (previously only checked tenant ID)
- Updated all references throughout the template to use the new variable name and logic
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…/github.com/alzimmermsft/azure-sdk-for-java into AzSearch_SupportDifferentSubscriptionsInTme
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Check both tenant and subscription before attempting to use shared resources.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines