Skip to content

Conversation

@alzimmermsft
Copy link
Member

Description

Check both tenant and subscription before attempting to use shared resources.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Nov 6, 2025
Copilot AI review requested due to automatic review settings November 6, 2025 19:22
@alzimmermsft alzimmermsft requested review from a team as code owners November 6, 2025 19:22
@github-actions github-actions bot added the Search label Nov 6, 2025
@alzimmermsft
Copy link
Member Author

/azp run java - search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the conditional logic for accessing static test resources in the Azure Search Bicep template. The change ensures that static resources are only used when both the tenant ID and subscription ID match specific values, providing more precise control over resource selection.

Key Changes

  • Renamed variable from isTmeTenant to canUseStatic for clarity
  • Enhanced condition to check both tenant ID and subscription ID (previously only checked tenant ID)
  • Updated all references throughout the template to use the new variable name and logic

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@alzimmermsft
Copy link
Member Author

/azp run java - search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

/azp run java - search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

/azp run java - search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

/azp run java - search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft
Copy link
Member Author

/azp run java - search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft alzimmermsft merged commit 91844bc into Azure:main Nov 11, 2025
49 checks passed
@alzimmermsft alzimmermsft deleted the AzSearch_SupportDifferentSubscriptionsInTme branch November 11, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants