Skip to content

Conversation

@samvaity
Copy link
Member

Downgrading from Jedis 6.2.0 (Elastic-2.0 license) to Jedis 4.4.8

@samvaity samvaity marked this pull request as ready for review November 10, 2025 22:36
Copilot AI review requested due to automatic review settings November 10, 2025 22:37
Copilot finished reviewing on behalf of samvaity November 10, 2025 22:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the Jedis dependency from version 6.2.0 to 4.4.8 across multiple modules to address licensing concerns with the Elastic-2.0 license present in Jedis 6.2.0.

Key changes:

  • Downgraded Jedis dependency from 6.2.0 to 4.4.8 in two modules and central dependency management
  • Updated Maven enforcer bannedDependencies rules to reflect the new version
  • Maintained consistency across all dependency declarations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
sdk/identity/azure-identity/pom.xml Updated Jedis test dependency from 6.2.0 to 4.4.8
sdk/eventhubs/azure-messaging-eventhubs-checkpointstore-jedis/pom.xml Downgraded Jedis runtime dependency from 6.2.0 to 4.4.8 and updated bannedDependencies rule to match
eng/versioning/external_dependencies.txt Updated central external dependency version for Jedis from 6.2.0 to 4.4.8

<groupId>redis.clients</groupId>
<artifactId>jedis</artifactId>
<version>6.2.0</version> <!-- {x-version-update;redis.clients:jedis;external_dependency} -->
<version>4.4.8</version> <!-- {x-version-update;redis.clients:jedis;external_dependency} -->
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG.md file for this module should be updated to document this dependency downgrade from Jedis 6.2.0 to 4.4.8. According to the PR guidelines and best practices, dependency changes should be documented in the CHANGELOG.md under the "Other Changes" section with "Dependency Updates" subsection. The current unreleased version (1.0.0-beta.5) section should include:

#### Dependency Updates

- Downgraded `jedis` from `6.2.0` to version `4.4.8`.

This is particularly important as it's a downgrade (not an upgrade), likely due to licensing concerns with the Elastic-2.0 license in Jedis 6.2.0.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

1 participant