[Groundedness] Check for right schema #43927
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
Copilot finished reviewing on behalf of
ahibrahimm
November 11, 2025 00:11
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the GroundednessEvaluator class to improve schema validation for context extraction. The changes include code organization improvements, the introduction of a new helper method for context validation, and enhanced error handling for edge cases.
Key changes:
- Extracted context validation logic into a dedicated
_validate_context()method to improve code reusability - Added
_is_single_entry()method to determine if inputs represent single entries - Removed redundant instance variable assignments in favor of using parent class properties directly
...valuation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_groundedness/_groundedness.py
Show resolved
Hide resolved
...valuation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_groundedness/_groundedness.py
Outdated
Show resolved
Hide resolved
...valuation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_groundedness/_groundedness.py
Show resolved
Hide resolved
ashaabansoliman
approved these changes
Nov 11, 2025
Contributor
ashaabansoliman
left a comment
ashaabansoliman
left a comment
There was a problem hiding this comment.
Approving with a known issue only in case of concurrency as explained in the comment, which is kinda corner case.
Another PR should follow to fix the concurrency issue
ashaabansoliman
approved these changes
Nov 11, 2025
Contributor
ashaabansoliman
left a comment
ashaabansoliman
left a comment
There was a problem hiding this comment.
Approving with a known issue only in case of concurrency as explained in the comment, which is kinda corner case.
Another PR should follow to fix the concurrency issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines