Skip to content

SWI-8362 Fix tracks Capitalization for StartStream #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

SWI-8362 Fix tracks Capitalization for StartStream #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/main/java/com/bandwidth/sdk/model/bxml/StartStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
import jakarta.xml.bind.annotation.XmlElements;
import jakarta.xml.bind.annotation.XmlType;
import java.util.List;
import java.util.UUID;

import com.bandwidth.sdk.model.CallDirectionEnum;

import lombok.AllArgsConstructor;
import lombok.Builder;
Expand Down Expand Up @@ -84,7 +82,7 @@ public class StartStream implements Verb {

@XmlAttribute
@Default
protected CallDirectionEnum tracks = CallDirectionEnum.INBOUND;
protected TracksEnum tracks = TracksEnum.inbound;

@XmlAttribute
protected String destination;
Expand Down
18 changes: 18 additions & 0 deletions src/main/java/com/bandwidth/sdk/model/bxml/TracksEnum.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.bandwidth.sdk.model.bxml;

public enum TracksEnum {

inbound("inbound"),

outbound("outbound");

private String value;

TracksEnum(String value) {
this.value = value;
}

public String getValue() {
return value;
}
}
6 changes: 3 additions & 3 deletions src/test/java/com/bandwidth/sdk/unit/models/bxml/StartStreamVerbTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@

package com.bandwidth.sdk.unit.models.bxml;

import com.bandwidth.sdk.model.CallDirectionEnum;
import com.bandwidth.sdk.model.bxml.Bxml;
import com.bandwidth.sdk.model.bxml.StartStream;
import com.bandwidth.sdk.model.bxml.StreamParam;
import com.bandwidth.sdk.model.bxml.TracksEnum;

import jakarta.xml.bind.JAXBContext;
import jakarta.xml.bind.JAXBException;
Expand All @@ -38,7 +38,7 @@ public class StartStreamVerbTest {
StartStream startStream = StartStream.builder()
.name("stream1")
.mode("unidirectional")
.tracks(CallDirectionEnum.INBOUND)
.tracks(TracksEnum.inbound)
.destination("testurl.com")
.streamEventUrl("eventurl.com")
.streamEventMethod("POST")
Expand All @@ -50,7 +50,7 @@ public class StartStreamVerbTest {
@Test
public void startStreamVerbWorks() throws JAXBException {
JAXBContext jaxbContext = JAXBContext.newInstance(Bxml.class);
String expectedBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><StartStream name=\"stream1\" mode=\"unidirectional\" tracks=\"INBOUND\" destination=\"testurl.com\" streamEventUrl=\"eventurl.com\" streamEventMethod=\"POST\" username=\"user\" password=\"pass\"><StreamParam name=\"name1\" value=\"value1\"/><StreamParam name=\"name2\" value=\"value2\"/></StartStream></Bxml>";
String expectedBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><StartStream name=\"stream1\" mode=\"unidirectional\" tracks=\"inbound\" destination=\"testurl.com\" streamEventUrl=\"eventurl.com\" streamEventMethod=\"POST\" username=\"user\" password=\"pass\"><StreamParam name=\"name1\" value=\"value1\"/><StreamParam name=\"name2\" value=\"value2\"/></StartStream></Bxml>";

assertThat(new Bxml().with(startStream).toBxml(jaxbContext), is(expectedBxml));
}
Expand Down