Skip to content

VAPI-2276 Update smoke tests for Voice APIs #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

VAPI-2276 Update smoke tests for Voice APIs #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dcccab5
Unskip test_conference_recordings to address PV issues
smoghe-bw Aug 7, 2025
be74711
Trigger build
smoghe-bw Aug 8, 2025
360b6ab
Add .env to .gitignore for local testing
smoghe-bw Aug 8, 2025
87e1f5a
Unskip test_conference_recordings and adjust polling logic for record…
smoghe-bw Aug 12, 2025
ed1b5ec
Merge branch 'main' into fix-pv-issues
smoghe-bw Aug 12, 2025
238766d
Refactor test_conference_recordings to implement retry logic for reco…
smoghe-bw Aug 12, 2025
8999b46
Merge branch 'fix-pv-issues' of github.com:Bandwidth/python-sdk into …
smoghe-bw Aug 12, 2025
33189da
Add initialization for list_conference_recordings_response in test_co…
smoghe-bw Aug 12, 2025
76d204b
Refactor test_conference_recordings to simplify recording availabilit…
smoghe-bw Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,6 @@ target/

# Test Fixtures
test/fixtures/

# Local testing
.env
13 changes: 2 additions & 11 deletions test/smoke/test_conferences_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ def test_conference_and_members(self):
BW_ACCOUNT_ID, call_id, update_call
)

@unittest.skip("PV Issues")
def test_conference_recordings(self) -> None:
"""
Tests a successful flow of creating a call with a recording.
Expand All @@ -271,16 +270,8 @@ def test_conference_recordings(self) -> None:
BW_ACCOUNT_ID, conference_id, updateBxmlBody)
assert_that(update_conference_bxml_response.status_code, 204)

# Poll Manteca to ensure our conference is recorded
call_status = self.get_test_status(test_id)
retries = 0
while call_status['callRecorded'] == False and retries < self.MAX_RETRIES:
time.sleep(self.TEST_SLEEP)
call_status = self.get_test_status(test_id)
retries += 1

# If we failed to get a recorded conference, fail due to polling timeout
assert call_status['callRecorded'] == True
# Sleep 15 seconds to ensure recording exists
time.sleep(15)

list_conference_recordings_response: ApiResponse = self.conference_api_instance.list_conference_recordings_with_http_info(
BW_ACCOUNT_ID, conference_id)
Expand Down
Loading