fix(prometheus): Fix Prometheus metric collection in a multi-workers … #14929
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sotazhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
please fix the prometheus.py linting errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In multi-worker instances, metrics between Prometheus clients are calculated independently.
For example:
worker0: metric.counter=1
worker1: metric.counter=2
When requesting /metrics api, what is returned metirc.counter=1 or 2, not 3(1+2)
When the PROMETHEUS_MULTIPROC_DIR environment variable was specified at that time, the prometheus client would store data in the specified directory.
After correct initialization, requesting the /metrics api of any worker could return the full amount of data from disk
Type
🐛 Bug Fix