Cursed Chrome Cookie Fix #1924
Merged
Cursed Chrome Cookie Fix #1924
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary upstream changed it's cookie values from a string value to a struct and the download command needed to be modified to work with the struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1758.
This Pull Request does a few things. It eliminates using a string to gather the JSON array from the remote site debugger. It now leverages the built-in library. It then takes the output and uses the ChromeDP Struct for JSON Marshalling items.
Please note that to make this work, a few other things had to be done, including running the following commands on the CLI.
Due to the many changes this introduces, I can make the changes part of this PR or the maintainers can attempt it. Will look at backporting this to 1.5.X.