Skip to content

Conversation

@shonsirsha
Copy link
Collaborator

No description provided.

@thisconnect thisconnect self-requested a review November 5, 2025 14:31
Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested LGTM (as there was no conflicts and ci seems happy)

@benma
Copy link
Contributor

benma commented Nov 10, 2025

If there are no confllicts, why not merge staging to master? 😄

edit: like this, I just opened the PR from the branch: #3675

edit2: a conflict now appeared, so I closed the above PR, please continue here by resolving the conflict 😄

Backend and simulator logs in the Github Action's logs are confusing, hard to scroll
and get mixed with Playwright's logs. Instead, we redirect them to file
and upload them as artifacts.
Without this, the app can not be used together with the simulator when
using regtest.
@thisconnect
Copy link
Collaborator

I merged locally and opened a PR to staging, so with that stagigng is mergeable. #3682

but then I found another small issue here is the fix #3683

@thisconnect
Copy link
Collaborator

merged in #3686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants