Fix issue 173 relating to zombie connections from Socket #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpicyPete
approved these changes
Feb 17, 2020
SpicyPete
left a comment
SpicyPete
left a comment
There was a problem hiding this comment.
Looks like great changes, thank you for submitting these!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173 by adding a small enum-based state machine to track whether an instance is initialised and if so what connection type (socket.io vs BitSocket) it is being used for.
Once an instance is of a certain type, queries of the other type or queries of same type that require a new connection will throw an error. This ensures that at most one connection exists at any time so that calling
close()results in zero open connections.