ios: Remove deployment-target #736
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump on this, would like this merged as it's causing issues with cordova-plugin-firebasex pods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-XXXX -- <TITLE>.
Summary
Motivation
Preference
deployment-targetshould be defined in config.xml https://cordova.apache.org/docs/en/latest/config_ref/index.htmlThe value from the plugin overrides the value from config.xml
Value from config.xml should have more priority than value from the plugin
Please remove this preference and add it to the documentation.
https://help.branch.io/developers-hub/docs/cordova-phonegap-ionic#configure-app
Type Of Change
Testing Instructions
cc @BranchMetrics/saas-sdk-devs for visibility.