EMT-2127-Split-spm-targets-and-add-swift-code. #1502
Conversation
… with v1/install request.
This reverts commit 0ad4564.
This reverts commit 53d322c.
This reverts commit ef025f1.
-> Removed DeepLinkDemo, TestDeepLinking and TestHost Apps for the repo. -> Removed Unit tests from Branch Test Bed App -> Added Test Host App and Unit tests to BranchSDK Workspace.
This reverts commit 83cd178.
|
Summary By MatterAI
🔄 What ChangedThis Pull Request introduces significant architectural improvements and refactoring to the Branch SDK, primarily focusing on modularization and modernizing configuration management.
🔍 Impact of the ChangeThe changes significantly improve the SDK's maintainability, build performance, and future extensibility, especially for projects using Swift Package Manager. By separating Objective-C and Swift codebases into distinct modules, it reduces coupling and clarifies dependencies. The migration to a Swift-based configuration controller modernizes the internal architecture and leverages Swift's features for better type safety and concurrency management (via 📁 Total Files Changed7 files were changed in this Pull Request. 🧪 Test AddedNo new explicit test files were added in this PR. However, the existing pre-release QA workflows in
These comprehensive existing tests will validate that the architectural changes and configuration migration do not introduce regressions and that the SDK continues to function correctly across various integration methods. 🔒Security VulnerabilitiesNo new security vulnerabilities were detected. The changes primarily involve refactoring and build system updates, which do not introduce new attack surfaces. The use of Tip Quality Recommendations
Sequence DiagramsequenceDiagram
participant App as Application
participant GH_Actions as GitHub Actions
participant ObjC_SDK as BranchSDK (Objective-C)
participant Swift_SDK as BranchSwiftSDK
participant Config_Controller as ConfigurationController (Swift)
GH_Actions->>GH_Actions: Update runner to macos-15
Note over GH_Actions: All test jobs (CocoaPods, SPM, Manual) will run on macos-15
App->>ObjC_SDK: Initialize Branch SDK
Note over ObjC_SDK: Calls from Branch.m, BNCRequestFactory.m
ObjC_SDK->>+Config_Controller: ConfigurationController.shared
Note over Config_Controller: Accesses singleton instance (via @MainActor)
ObjC_SDK->>Config_Controller: setBranchKeySource(source: String)
ObjC_SDK->>Config_Controller: setDeferInitForPluginRuntime(value: Bool)
ObjC_SDK->>Config_Controller: setCheckPasteboardOnInstall(value: Bool)
ObjC_SDK->>+Config_Controller: getConfiguration()
Config_Controller->>Config_Controller: branchKeyInfo()
Config_Controller->>Config_Controller: featureFlagsInfo()
Config_Controller->>Config_Controller: frameworkIntegrationInfo()
Config_Controller-->>-ObjC_SDK: return configDictionary
ObjC_SDK-->>App: SDK Initialized / Request Processed
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
NidhiDixit09
changed the title
|
Note PR Review SkippedPR review skipped as no relevant changes found due to large diff hunk OR part of a non-reviewable file. 📄Files skipped in review
💡Tips to use Matter AICommand List
|
Reference
EMT-2127 - Add swift code and bridging header in SDK
https://branch.atlassian.net/browse/EMT-2127
Summary
-> Converted objective-c class BranchConfigurationController to a swift class ConfigurationController.
-> Split Source folder / SPM Package into three targets - BranchObjCSDK (for core Objective-C classes), BranchSwiftSDK (for Swift classes which uses files from BranchObjCSDK), and BranchSDK (the main public target and which uses files from BranchSwiftSDK as well as BranchObjCSDK).
-> Updated Project workspace and other integration methods for above changes.
Motivation
Converting objective-c code to swift.
Testing Instructions
Branch SDK integration with an app should succeed with all methods of integration (cocoapods, spm, carthage and manual integration).
cc @BranchMetrics/saas-sdk-devs for visibility.