Skip to content

EMT-2244 Source Code Restructure and Cleanup #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: EMT-2127-Split-SPM-Targets-POC
Choose a base branch
from

Conversation

NidhiDixit09
Copy link
Collaborator

@NidhiDixit09 NidhiDixit09 commented Jul 16, 2025

Reference

EMT-2244 - Remove extra test Apps from repo and moved unit tests to BranchSDK project file.
https://branch.atlassian.net/browse/EMT-2244

Summary

--> Removed following test apps/folders -

  • DeepLink Demo
  • TestDeepLinking
  • TestHost
  • fastlane

--> Moved Unit tests to BranchSDK.xcodeproj workspace and added app BranchSDKTestsHostApp to run these tests.
--> Updated GHAs for above changes.

Testing Instructions

Source Code Build should be successful.
Unit Test Build and Run should be successful.
All GHA should pass.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link
Contributor

matter-code-review bot commented Jul 16, 2025

Code Quality refactoring build-process dependency-management

Summary By MatterAI MatterAI logo

🔄 What Changed

This Pull Request is a significant source code restructure and cleanup, primarily focused on the complete removal of the fastlane and CocoaPods related build and CI/CD configurations. The changes involve the deletion of:

  • Gemfile: Removal of Ruby gem dependencies, including cocoapods, activesupport, fastlane, pattern_patch, and slather.
  • fastlane/.gitignore: Deletion of the .gitignore file specific to fastlane outputs.
  • fastlane/Appfile, fastlane/Fastfile, fastlane/Matchfile, fastlane/Scanfile: Complete removal of all core fastlane configuration files that defined app identifiers, build lanes (e.g., prepare_pods, unit_tests, integration_tests, version_bump, current_version), code signing settings, and test configurations.
  • fastlane/lib/helper/cocoapods_helper.rb: Deletion of the Ruby helper script responsible for managing CocoaPods installations and checking for required updates.
  • fastlane/lib/helper/version_helper.rb: Deletion of the Ruby helper script used for updating SDK versions, including agvtool integration, BNCConfig.m, Branch.podspec, and Framework-Info.plist.

All changes are deletions, indicating a deprecation or migration away from these specific tools and their associated build processes.

🔍 Impact of the Change

This PR represents a major refactoring of the project's build and CI/CD infrastructure. The removal of fastlane and CocoaPods configurations implies that the project is either moving to a different set of tools for automation, dependency management, testing, and versioning, or these functionalities are no longer required in this specific repository. This change will directly impact any existing CI/CD pipelines or developer workflows that relied on these fastlane lanes and CocoaPods for building, testing, or releasing the SDK. It simplifies the codebase by removing deprecated or replaced build logic but necessitates a new or existing alternative system to handle these critical processes.

📁 Total Files Changed

8 files were changed, all of which were deletions.

🧪 Test Added

No new tests were added or modified in this Pull Request. The changes exclusively involve the removal of existing build and CI/CD configuration files and helper scripts.

🔒 Security Vulnerabilities

No new security vulnerabilities were introduced or fixed in the provided patch, as the changes consist solely of file removals. The implications for security would depend on the new build/CI system that replaces the removed fastlane and CocoaPods configurations, which is not part of this PR.

Tip

Quality Recommendations

  1. Given the extensive removal of build and CI/CD configurations, it is crucial to provide comprehensive documentation explaining the rationale behind these removals and detailing the new processes or tools that will replace them. This should include instructions for developers and CI/CD engineers.

  2. If this PR is part of a larger migration, ensure that the new build and CI/CD system is already in place or is being introduced concurrently. Lack of a replacement could lead to broken pipelines and workflows.

  3. Explicitly state the impact of these changes on existing CI/CD pipelines and developer local build environments in the PR description or an accompanying document. This helps stakeholders understand the necessary adjustments.

  4. Consider adding a follow-up task or PR to remove any lingering references to the fastlane or CocoaPods setup in other parts of the codebase or documentation that might not have been covered by these file removals.

Sequence Diagram

sequenceDiagram
    participant OldBuildSystem as "Old Build System"
    participant FastlaneConfig as "Fastlane Configuration"
    participant CocoapodsHelpers as "CocoaPods Helpers"
    participant Gemfile as "Gemfile Dependencies"
    participant Repository as "Code Repository"

    Repository->>FastlaneConfig: Contains Fastlane Files
    Repository->>CocoapodsHelpers: Contains Helper Scripts
    Repository->>Gemfile: Defines Ruby Dependencies

    OldBuildSystem->>FastlaneConfig: Relies on Fastlane for CI/CD
    OldBuildSystem->>CocoapodsHelpers: Uses Helpers for Pod Management
    OldBuildSystem->>Gemfile: Installs Ruby Gems

    Note over Repository,OldBuildSystem: Source Code Restructure Cleanup (Removal Action)

    Repository--xFastlaneConfig: Files Removed (Appfile, Fastfile, Matchfile, Scanfile)
    Repository--xCocoapodsHelpers: Scripts Removed (cocoapods_helper.rb, version_helper.rb)
    Repository--xGemfile: Dependencies Removed (Gemfile)

    OldBuildSystem--xOldBuildSystem: Fastlane/CocoaPods Integration Decommissioned
Loading

Copy link
Contributor

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with Matter AI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

Copy link
Contributor

Note

PR Review Skipped

PR review skipped as no relevant changes found due to large diff hunk OR part of a non-reviewable file.

📄Files skipped in review
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
💡Tips to use Matter AI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with Matter AI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

Copy link
Contributor

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with Matter AI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

@NidhiDixit09 NidhiDixit09 changed the title Emt 2244 source code restructure cleanup EMT - 2244 Source Code Restructure and Cleanup Jul 16, 2025
@NidhiDixit09 NidhiDixit09 changed the title EMT - 2244 Source Code Restructure and Cleanup EMT-2244 Source Code Restructure and Cleanup Jul 16, 2025
@NidhiDixit09 NidhiDixit09 marked this pull request as ready for review July 16, 2025 10:47
Copy link
Contributor

Note

PR Review Skipped

PR review skipped as no relevant changes found due to large diff hunk OR part of a non-reviewable file.

📄Files skipped in review
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
  • undefined: undefined
💡Tips to use Matter AI

Command List

  • /matter summary: Generate AI Summary for the PR
  • /matter review: Generate AI Reviews for the latest commit in the PR
  • /matter review-full: Generate AI Reviews for the complete PR
  • /matter release-notes: Generate AI release-notes for the PR
  • /matter : Chat with your PR with Matter AI Agent
  • /matter remember : Generate AI memories for the PR
  • /matter explain: Get an explanation of the PR
  • /matter help: Show the list of available commands and documentation
  • Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants