Skip to content

Conversation

@athul-ab
Copy link
Collaborator

No description provided.

athul-ab and others added 3 commits November 16, 2025 16:11
…, and z-index

Fixes 4 critical issues in OAuth connector authentication flow:

**Issue #1: URL Parameter Pollution**
- Removed URL manipulation from useOAuthCallback hook
- AgentDrawer now single source of truth for URL updates
- Prevents duplicate prompt IDs in URL

**Issue #2: Double Agent Box Creation**
- Added OAuth callback detection in AgentDrawer
- Prevents creating new session during OAuth flow
- Preserves original session instead of duplicating

**Issue #3: URL Cleanup Strategy**
- Updated ConnectorDetails to preserve agent/prompt params
- Only removes OAuth-specific params (code, state, connector)
- Fixes race condition between multiple URL cleanups

**Issue #4: Z-Index Stacking**
- Set AgentDrawer z-index to 1050
- Ensures AgentDrawer appears above AddAgent drawer
- Proper visual hierarchy maintained

**Files Changed:**
- src/hooks/useOAuthCallback.ts: Removed URL manipulation logic
- src/components/agents/AgentDrawer.tsx: Added OAuth detection + z-index fix
- src/components/agents/tools/ConnectorDetails.tsx: Selective URL cleanup

**Testing:**
- OAuth flow now preserves single session
- URL correctly shows single prompt ID
- OAuth params properly cleaned up
- Drawer stacking order corrected

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @athul-ab, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the application's 'Prompts & Agents' section by renaming it simply to 'Agents' and updating all associated routes and UI elements. It also introduces more robust handling for OAuth callbacks, ensuring a smoother user experience by preventing unnecessary session re-initialization and intelligently managing URL parameters. Furthermore, the visual presentation of tool details has been refined for better clarity and user comprehension.

Highlights

  • Feature Renaming and Routing: The 'Prompts & Agents' feature has been renamed to 'Agents' across the application, including file paths, navigation labels, and Next.js routing configurations for better clarity and consistency.
  • Enhanced OAuth Callback Handling: Improved the OAuth callback flow to prevent redundant session creation in the AgentDrawer and to ensure that only OAuth-specific parameters are removed from the URL, preserving other relevant query parameters.
  • UI/UX Improvements for Tool Details: The ToolDetails component received updates to enhance readability and presentation of tool parameters, including a new utility to format parameter names and adjustments to layout and styling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the 'prompts & agents' feature into just 'agents', updating routes, navigation, and related logic. The changes also improve the OAuth callback flow by preserving URL parameters and preventing unnecessary session creation. My review focuses on improving code quality and maintainability. I've pointed out a leftover debug log, an opportunity to reduce code duplication, and a way to simplify a regular expression chain. Overall, the changes are positive and improve the user experience and codebase structure.

@athul-ab athul-ab requested a review from sanu17 November 16, 2025 13:07
- Remove unused imports from AgentDrawer
- Simplify ConnectorDetails component layout
- Clean up ToolDetails component
- Remove commented code from agents index page

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@athul-ab athul-ab merged commit 14fde5e into master Nov 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants