Skip to content

feat: CSVReader typescript improvements | style object type casting refactoring #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: CSVReader typescript improvements | style object type casting refactoring #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7f34851
add proper element and function types
berkinanik Feb 24, 2023
b2a1e59
add generic element type for div or input element type
berkinanik Feb 24, 2023
560d216
update example and use cases with proper type inference
berkinanik Feb 24, 2023
c9d20fb
refactor css property type definitions and add types to style props
berkinanik Feb 24, 2023
093deb5
fix no result is printed on local csv file examples on demo page
berkinanik Feb 24, 2023
ca6e786
add js-docs for useCSVReader hook usage with generic types
berkinanik Feb 24, 2023
9bfc302
apply prettier fixes
berkinanik Feb 25, 2023
8dd45a7
remove explicitly typed event: DragEvent from examples
berkinanik Feb 25, 2023
b25ac12
fix clear input ref value
berkinanik Feb 27, 2023
cddad8e
set parse result data type to string array default
berkinanik Feb 27, 2023
3339b6e
update examples with generic string array data type
berkinanik Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 65 additions & 70 deletions README.md
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 11 additions & 3 deletions docs/src/components/screens/Demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useEffect, useState } from 'react';
import { Tab, Tabs, TabList, TabPanel } from 'react-tabs';

import { usePapaParse, useCSVReader, lightenDarkenColor, formatFileSize } from 'react-papaparse';
Expand Down Expand Up @@ -169,6 +169,14 @@ export default function Demo() {
}
]`);

useEffect(() => {
if (csvData) {
console.log('---------------------------');
console.log(csvData);
console.log('---------------------------');
}
}, [csvData]);

const handleSelect = (index) => {
setTabIndex(index);
};
Expand Down Expand Up @@ -314,7 +322,7 @@ export default function Demo() {
<>
<div style={buttonStyles.csvReader}>
<button
type="button"
type='button'
{...getRootProps()}
style={buttonStyles.browseFile}
>
Expand Down Expand Up @@ -905,7 +913,7 @@ export default class Demo extends Component {
}}
>
<button
type="button"
type='button'
onClick={this.handleOpenDialog}
style={{
borderRadius: 0,
Expand Down
40 changes: 20 additions & 20 deletions docs/src/components/screens/docs/CSVToJSON.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const CSVToJSON = () => {
<pre>
<code className="language-javascript">
{`<CSVReader
onUploadAccepted={(results: any) => {
onUploadAccepted={(results) => {
console.log('---------------------------');
console.log(results);
console.log('---------------------------');
Expand All @@ -75,7 +75,7 @@ const CSVToJSON = () => {
acceptedFile,
ProgressBar,
getRemoveFileProps,
}: any) => (
}) => (
<>
<div style={styles.csvReader}>
<button type='button' {...getRootProps()} style={styles.browseFile}>
Expand Down Expand Up @@ -135,17 +135,17 @@ const CSVToJSON = () => {
<pre>
<code className="language-javascript">
{`<CSVReader
onUploadAccepted={(results: any) => {
onUploadAccepted={(results) => {
console.log('---------------------------');
console.log(results);
console.log('---------------------------');
setZoneHover(false);
}}
onDragOver={(event: DragEvent) => {
onDragOver={(event) => {
event.preventDefault();
setZoneHover(true);
}}
onDragLeave={(event: DragEvent) => {
onDragLeave={(event) => {
event.preventDefault();
setZoneHover(false);
}}
Expand All @@ -156,7 +156,7 @@ const CSVToJSON = () => {
ProgressBar,
getRemoveFileProps,
Remove,
}: any) => (
}) => (
<>
<div
{...getRootProps()}
Expand All @@ -181,11 +181,11 @@ const CSVToJSON = () => {
<div
{...getRemoveFileProps()}
style={styles.remove}
onMouseOver={(event: Event) => {
onMouseOver={(event) => {
event.preventDefault();
setRemoveHoverColor(REMOVE_HOVER_COLOR_LIGHT);
}}
onMouseOut={(event: Event) => {
onMouseOut={(event) => {
event.preventDefault();
setRemoveHoverColor(DEFAULT_REMOVE_HOVER_COLOR);
}}
Expand Down Expand Up @@ -239,17 +239,17 @@ const CSVToJSON = () => {
<pre>
<code className="language-javascript">
{`<CSVReader
onUploadAccepted={(results: any) => {
onUploadAccepted={(results) => {
console.log('---------------------------');
console.log(results);
console.log('---------------------------');
setZoneHover(false);
}}
onDragOver={(event: DragEvent) => {
onDragOver={(event) => {
event.preventDefault();
setZoneHover(true);
}}
onDragLeave={(event: DragEvent) => {
onDragLeave={(event) => {
event.preventDefault();
setZoneHover(false);
}}
Expand All @@ -261,7 +261,7 @@ const CSVToJSON = () => {
ProgressBar,
getRemoveFileProps,
Remove,
}: any) => (
}) => (
<>
<div
{...getRootProps()}
Expand All @@ -286,11 +286,11 @@ const CSVToJSON = () => {
<div
{...getRemoveFileProps()}
style={styles.remove}
onMouseOver={(event: Event) => {
onMouseOver={(event) => {
event.preventDefault();
setRemoveHoverColor(REMOVE_HOVER_COLOR_LIGHT);
}}
onMouseOut={(event: Event) => {
onMouseOut={(event) => {
event.preventDefault();
setRemoveHoverColor(DEFAULT_REMOVE_HOVER_COLOR);
}}
Expand Down Expand Up @@ -348,17 +348,17 @@ const CSVToJSON = () => {
<pre>
<code className="language-javascript">
{`<CSVReader
onUploadAccepted={(results: any) => {
onUploadAccepted={(results) => {
console.log('---------------------------');
console.log(results);
console.log('---------------------------');
setZoneHover(false);
}}
onDragOver={(event: DragEvent) => {
onDragOver={(event) => {
event.preventDefault();
setZoneHover(true);
}}
onDragLeave={(event: DragEvent) => {
onDragLeave={(event) => {
event.preventDefault();
setZoneHover(false);
}}
Expand All @@ -370,7 +370,7 @@ const CSVToJSON = () => {
ProgressBar,
getRemoveFileProps,
Remove,
}: any) => (
}) => (
<>
<div
{...getRootProps()}
Expand All @@ -395,11 +395,11 @@ const CSVToJSON = () => {
<div
{...getRemoveFileProps()}
style={styles.remove}
onMouseOver={(event: Event) => {
onMouseOver={(event) => {
event.preventDefault();
setRemoveHoverColor(REMOVE_HOVER_COLOR_LIGHT);
}}
onMouseOut={(event: Event) => {
onMouseOut={(event) => {
event.preventDefault();
setRemoveHoverColor(DEFAULT_REMOVE_HOVER_COLOR);
}}
Expand Down
Loading