Fix AttributeError in PDFPageInterpreterEx by using graphicstate.ncs/scs #1008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a runtime error when using
pdf2zhon certain PDF files, specifically related to incorrect access ofncsandscsattributes within thePDFPageInterpreterExclass.When running the following command on macOS with Python 3.9 and LibreSSL:
pdf2zh "[Reading] Exploring the spillover effects of WeChat using graphical model.pdf" -li en -lo ko -s ollamaThe following error is raised:
Cause
The
ncs(non-stroking color space) andscs(stroking color space) attributes are not defined directly onPDFPageInterpreterExbut are part of the internalgraphicstateobject. This structure is consistent with the originalpdfminer.sixdesign. However,pdf2zhincorrectly usesself.ncsandself.scs, resulting in anAttributeError.Fix
self.ncsandself.scsare replaced withself.graphicstate.ncsandself.graphicstate.scsself.ncs = interpreter.ncsindo_Doare updated toself.graphicstate.ncs = interpreter.graphicstate.ncsResult
After this fix,
pdf2zhruns successfully and processes all pages without error:Environment
uvNotes
pdfminer.six's handling of color state (SCN, scn) logic