Skip to content

[Rust] Fixes to Net Module #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

steel-bucket
Copy link
Contributor

@steel-bucket steel-bucket commented Aug 9, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

The net module is not working in either the main branch or the rust port(open currently), this PR aims to solve it by re-writing the UDP implementation and some changes to the parser module..

I've added it so that I could run regressions, so there could be a chance of errors still. But it seems to run fine locally.

To get it to run in your local system

Let's say we are testing on a hauppauge file all_in_with_chris_hayes_20250326_1958.ts
(hauppauge used so that I could showcase where to put the Args)
We would normally do

cd ./linux
./build
./ccextractor --hauppauge  ~/ccxtesting/all_in_with_chris_hayes_20250326_1958.ts 
So, for testing the TCP implementation locally, we have to run this command (Make sure that netcat is installed in linux)
./ccextractor --tcp 1212

In another terminal

 ./ccextractor --hauppauge  ~/ccxtesting/all_in_with_chris_hayes_20250326_1958.ts  --sendto localhost:1212
And for testing the UDP implementation
ccextractor --hauppauge --srt --udp 1235 --stdout

In another terminal

nc -u -w 1 localhost 1235 < ~/ccxtesting/all_in_with_chris_hayes_20250326_1958.ts

These 2 tests work on this branch, and in 0.94(and older releases), but they are non-functional for the main branch as well as the old net PRs.
All Credit for porting the core codebase of net goes to @elbertronnie and @IshanGrover2004

@steel-bucket steel-bucket force-pushed the migration-net-module-fixes branch from 6de4045 to ead8b81 Compare August 9, 2025 15:46
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit afde4d6...:
Report Name Tests Passed
Broken 13/13
CEA-708 13/14
DVB 7/7
DVD 0/3
DVR-MS 2/2
General 22/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 83/86
Teletext 21/21
WTV 13/13
XDS 33/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:

  • ccextractor --service 1 --out=txt f17524b53f..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed:

    Never

  • ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed:

    Never

  • ccextractor --unicode c83f765c66..., Last passed:

    Never

  • ccextractor --in=ps e9b9008fdf..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed:

    Never


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit afde4d6...:
Report Name Tests Passed
Broken 13/13
CEA-708 13/14
DVB 2/7
DVD 0/3
DVR-MS 2/2
General 22/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 82/86
Teletext 7/21
WTV 10/13
XDS 33/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:

  • ccextractor --service 1 --out=txt f17524b53f..., Last passed:

    Never

  • ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

    Never

  • ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

    Never

  • ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed:

    Never

  • ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed:

    Never

  • ccextractor --unicode c83f765c66..., Last passed:

    Never

  • ccextractor --in=ps e9b9008fdf..., Last passed:

    Never

  • ccextractor --out=srt --latin1 f23a544ba8..., Last passed:

    Never

  • ccextractor --out=srt --latin1 10f0f77cf4..., Last passed:

    Test 5913

  • ccextractor --out=srt --latin1 df3b4d62d3..., Last passed:

    Never

  • ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed:

    Never


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants