-
Notifications
You must be signed in to change notification settings - Fork 473
[Rust] Fixes to Net Module #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Rust] Fixes to Net Module #1725
Conversation
feat: Create new module `net` in lib_ccxr
6de4045
to
ead8b81
Compare
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit afde4d6...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit afde4d6...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
The
net
module is not working in either the main branch or the rust port(open currently), this PR aims to solve it by re-writing the UDP implementation and some changes to theparser
module..I've added it so that I could run regressions, so there could be a chance of errors still. But it seems to run fine locally.
To get it to run in your local system
Let's say we are testing on a hauppauge file
all_in_with_chris_hayes_20250326_1958.ts
(hauppauge used so that I could showcase where to put the Args)
We would normally do
So, for testing the TCP implementation locally, we have to run this command (Make sure that netcat is installed in linux)
In another terminal
And for testing the UDP implementation
In another terminal
These 2 tests work on this branch, and in 0.94(and older releases), but they are non-functional for the main branch as well as the old net PRs.
All Credit for porting the core codebase of
net
goes to @elbertronnie and @IshanGrover2004