Skip to content

[FIX] Regression bug failing to compile with ENABLE_FFMPEG #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rboy1
Copy link
Contributor

@rboy1 rboy1 commented Aug 12, 2025

In raising this pull request, I confirm the following (please check boxes):

  • [ X] I have read and understood the contributors guide.
  • [ X] I have checked that another pull request for this purpose does not exist.
  • [ X] I have considered, and confirmed that this submission will be valuable to others.
  • [X ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [X ] I give this submission freely, and claim no ownership to its content.
  • [X ] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • [X ] I am an active contributor to CCExtractor.

Regression bug, ccextractor failed to build with ENABLE_FFMPEG using ffmpeg 5 libraries

Bug was introduced while patching in ref #1418 and #1479

rboy1 added 5 commits August 11, 2025 22:14
Fix unresolved function reference when compiling with ENABLE_FFMPEG
Fix regression bug for compiling with ENABLE_FFMPEG and ffmpeg 5, introduced in CCExtractor#1418
Fix regression compilation ffmpeg_intgr.c to support ffmpeg 5
[FIX] Regression bug failing to compile with ENABLE_FFMPEG
@rboy1
Copy link
Contributor Author

rboy1 commented Aug 14, 2025

There are two more errors which popped up related to this during linking that need a patch. Do you want me to add the changes to this pull or should I create a new pull for it?

@prateekmedia
Copy link
Member

@rboy1 separate PR if its unrelated.

Update for changes to FFMPEG 5 API
@rboy1
Copy link
Contributor Author

rboy1 commented Aug 15, 2025

@rboy1 separate PR if its unrelated.

It's related to the FFMPEG 5 API changes (also builds with ffmpeg 7.1.1), updated the pull request to include those changes. I'm now able to build this without any errors. If you're good with it please go ahead and merge the changes.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 39e051b...:
Report Name Tests Passed
Broken 13/13
CEA-708 13/14
DVB 7/7
DVD 0/3
DVR-MS 2/2
General 22/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 84/86
Teletext 21/21
WTV 10/13
XDS 33/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 39e051b...:
Report Name Tests Passed
Broken 13/13
CEA-708 13/14
DVB 2/7
DVD 0/3
DVR-MS 2/2
General 22/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 83/86
Teletext 7/21
WTV 10/13
XDS 33/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants