Skip to content

Conversation

@ntarocco
Copy link
Contributor

Records are created by fixtures before running tests.
GIven that now you have added on insert, edit and delete signal for stats, you need to have Rabbit MQ up and running when testing.

@ntarocco
Copy link
Contributor Author

Side comment: the insert/edit/delete signal are trigger for any type of record, even Locations for example. Do we want that?
Or do we want to pre-filter what records should be sent to the stats indices, before the signal is fired (to avoid the message in the queue)?

Copy link
Contributor

@JakobMiesner JakobMiesner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@JakobMiesner
Copy link
Contributor

JakobMiesner commented Nov 11, 2025

Side comment: the insert/edit/delete signal are trigger for any type of record, even Locations for example. Do we want that? Or do we want to pre-filter what records should be sent to the stats indices, before the signal is fired (to avoid the message in the queue)?

Originally the library only requested the stat for Document, Items, E-items (see 4. here)
I did not see any harm in collecting the stat for all ILSRecords (required less code and the data might come in handy later). If wanted, I can easily filter all other records out in the event builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants