FIREFLY-1865: Incorrect pixel readout in 3-color with reprojection #1857
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robyww
reviewed
Oct 6, 2025
src/firefly/java/edu/caltech/ipac/firefly/server/visualize/WebPlotFactory.java
Outdated
Show resolved
Hide resolved
tgoldina
force-pushed
the
FIREFLY-1865_readout
branch
3 times, most recently
from
44fe5c5 to
06a6b67
Compare
|
@robyww Thank you for the suggestion. I’ve implemented it and rebuilt the project. Please re-review. |
tgoldina
force-pushed
the
FIREFLY-1865_readout
branch
from
06a6b67 to
7005de4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1865 (test images attached)
Test Build: https://fireflydev.ipac.caltech.edu/firefly-1865-readout/firefly
Fixed flux readout bug in 3-color image with re-projection.
To test: