Switch to AUTHORS.md #1901
Switch to AUTHORS.md #1901
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
- Coverage 74.11% 74.10% -0.02%
==========================================
Files 444 444
Lines 55556 55516 -40
Branches 9132 9128 -4
==========================================
- Hits 41177 41140 -37
+ Misses 11286 11285 -1
+ Partials 3093 3091 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Failing |
AUTHORS.md
Outdated
| - **Laurien Vandewalle** ([@lavdwall](https://github.com/lavdwall)) | ||
| - **Guillaume Vignat** ([@gvignat](https://github.com/gvignat)), Stanford University | ||
| - **Anthony Walker** ([@anthony-walker](https://github.com/anthony-walker)), Oregon State University | ||
| - **Bryan Weber** ([@bryanwweber](https://github.com/bryanwweber)), University of Connecticut |
There was a problem hiding this comment.
Can you remove this affiliation? It hasn't been accurate for three and a half years now 🫣
There was a problem hiding this comment.
😆 yeah. I'm actually thinking of updating the top statement to:
[...] Below is a partial, alphabetical list of developers and contributors to Cantera over the years, along with their last reported affiliation. If you've been left off or need an update, please report on Cantera's Github issue tracker.
As there are presumably several other issues, the only other viable alternative would be to strip affiliations, as this will be a recurring issue.
There was a problem hiding this comment.
Seems like a good update to me 😀
There was a problem hiding this comment.
I think the affiliation can just be handled by the tagged users on their own profiles.
There was a problem hiding this comment.
Fair point, @wandadars. I stripped the affiliations in an update, see https://github.com/ischoegl/cantera/blob/rename-authors-file/AUTHORS.md
There was a problem hiding this comment.
I'd really rather we kept the affiliations. I think the suggested update to the statement at the top is reasonable, with the expectation that the affiliation is generally one that is/was applicable at the time contributions to Cantera were being made.
There was a problem hiding this comment.
@speth - no worries. I kept the commits separate so I just reverted. I did, however, strip the parentheses as the links are visually clearly separated from names.
Also, switch to list, add links to GitHub handles, and typeset names in bold font.
ischoegl
force-pushed
the
rename-authors-file
branch
3 times, most recently
from
1f911f4 to
a15a63c
Compare
ischoegl
force-pushed
the
rename-authors-file
branch
from
a15a63c to
7493320
Compare
Changes proposed in this pull request
Use
AUTHORS.mdrather thanAUTHORS. Also, switch to list, add links to GitHub handles, and typeset names in bold font.See also: Cantera/cantera-website#272
PS: I also added an unrelated fix:
Fixes #1871.
If applicable, provide an example illustrating new features this pull request is introducing
For a rendered version, see https://github.com/ischoegl/cantera/blob/rename-authors-file/AUTHORS.md
Checklist
scons build&scons test) and unit tests address code coverage