refactor cleantitle.normalize in PTW #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Przeróbka funkcji normalizującej tytuł (UTF-8 → ASCII).
Wstawiam to co napisałem w ramach #40.
Podać można unicode jak i byte-coded string. Zwraca ASCII.
Obsługa małych i dużych liter. Plus kilka innych znaków.
Dzięki czemu mamy konwersję (zawsze można rozszerzyć
unicode_translate_table
jakby co):Działa w Python2 i Python3 (choć bytes jest średnio użyteczne).
Review
Proszę o review i sprawdzenie czy działa poprawnie (testy robiłem ale sobie nie ufam).