-
Notifications
You must be signed in to change notification settings - Fork 2.1k
improve v2-plot support in plot-sync #20238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+39
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
maybe the harvester protocol version number should be bumped |
almogdepaz
reviewed
Nov 13, 2025
almogdepaz
reviewed
Nov 13, 2025
9d6ba6d to
b69a9d4
Compare
Contributor
|
Contributor
Author
|
the missing test coverage is because we don't have any v2 plots in CI yet. This will be addressed |
almogdepaz
approved these changes
Nov 16, 2025
wjblanke
approved these changes
Nov 17, 2025
Contributor
wjblanke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Add support for v2 plots to the
Plotclass. This is part of the plot sync protocol and the harvester protocol. In order to support v2 plots, we need a strength field, but we also need to stay backwards compatible with previous versions of harvesters. e.g. DrPlotter.In order to do so, the
sizefield is reused to now either have the v1 plot size or the v2 plot strength. The most significant bit in theuint8field determines which one it is.The field was renamed from
sizetoparamto match the naming of similar fields in other parts of the code.Current Behavior:
the plot sync protocol does not support v2 plots.
New Behavior:
the plot sync protocol supports v2 plots