minor updates; stylistic touch-ups #35
Conversation
|
The diff here is extensive. Could you comment on the line changes that are more than stylistic touch-ups? |
|
@maxhutch Hmm, 1) Perhaps I used the wrong language, and 2) Perhaps it's a little intimidating, but I actually do think the changes leading to the massive diff, besides the three points I named, are stylistic in nature. I can certainly comment on what those are:
CitrinationClient(api_key=key,
site=site)instead of
|
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# data_client.delete_dataset(dataset_id=dataset_id)" |
There was a problem hiding this comment.
Added a block for client.data.delete_dataset(). It's commented out so someone doesn't accidentally do this.
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "### Example: Filter a range of values\n", |
There was a problem hiding this comment.
added an example to create a Filter with min and max
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "### Example: Logic\n", |
There was a problem hiding this comment.
Added an example with a Filter with logic.
| "source": [ | ||
| "<div class = \"intro\">\n", | ||
| "\n", | ||
| "# Sequential Learning Workshop\n", |
There was a problem hiding this comment.
This SL notebook uses a steel fatigue dataset instead of a toy function/data.
| @@ -0,0 +1,706 @@ | |||
| ''' | |||
| Authors: Eddie Kim, Enze Chen, Nils Persson | |||
There was a problem hiding this comment.
This is the corresponding wrapper for the steel fatigue SL demo.
|
@maxhutch Added comments where the changes actually took place. Thanks. :) |
maxhutch
left a comment
maxhutch
left a comment
There was a problem hiding this comment.
The changes look fine, but there is some weird formatting in the github render of:
https://github.com/CitrineInformatics/learn-citrination/blob/update-api-tutorials/citrination_api_examples/clients_sequence/6_sequential_learning_steel_fatigue.ipynb
Do you know what's going on there?
Wow; good catch! That's some leftover HTML formatting that's hidden when the Markdown renders in Jupyter, but apparently not on GitHub! :O I removed all of it—I think. |
Content updates are as follows:
client.data.delete_dataset()method.Also cleaned up the code to have better readability and flow based on iterative feedback and improvements from the past several months.