-
Notifications
You must be signed in to change notification settings - Fork 3
Update GovBanner Component #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…trol margin in light-DOM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The child element should not have the aria-expanded attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small tweaks requested. Nice work.
…hanges in govbanner file and fixed alignment issue on the right side of component when expanded and not expanded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what changed but the animation is now very jerky and the background color of the content area is incorrect on the left/right. Would you please correct those things?
Screen.Recording.2025-05-06.101537.mp4
2025-05-22.13-43-55.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreidthomas could you merge in dev and resolve the conflicts? Sorry for the conflicts. I had to make some nontrivial changes in #350 to support a feature for the site launch this week.
GovBanner needed some updates to improve styles and behavior
partattribute enabling it to be styled from the light DOM. Specifically, I should be able to override the left and right margins of the content so that the edges line up with the main content of the site where the banner is used.