Skip to content

Conversation

@sreidthomas
Copy link
Contributor

@sreidthomas sreidthomas commented Apr 17, 2025

GovBanner needed some updates to improve styles and behavior

  • The down chevron should rotate 180 degrees when the dropdown opens/closes to indicate the link now closes/opens the dropdown
  • The display of the content container should use an ease-in-out animation instead of abruptly appearing
  • The info section should be have a part attribute enabling it to be styled from the light DOM. Specifically, I should be able to override the left and right margins of the content so that the edges line up with the main content of the site where the banner is used.

@sreidthomas sreidthomas self-assigned this Apr 17, 2025
Copy link
Member

@jedgar1mx jedgar1mx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The child element should not have the aria-expanded attribute

@sreidthomas sreidthomas requested a review from jedgar1mx April 24, 2025 15:34
Copy link
Contributor

@maxatdetroit maxatdetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small tweaks requested. Nice work.

…hanges in govbanner file and fixed alignment issue on the right side of component when expanded and not expanded
Copy link
Contributor

@maxatdetroit maxatdetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what changed but the animation is now very jerky and the background color of the content area is incorrect on the left/right. Would you please correct those things?

Screen.Recording.2025-05-06.101537.mp4

@sreidthomas
Copy link
Contributor Author

2025-05-22.13-43-55.mp4

@sreidthomas sreidthomas requested a review from maxatdetroit June 9, 2025 13:26
Copy link
Contributor

@maxatdetroit maxatdetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreidthomas could you merge in dev and resolve the conflicts? Sorry for the conflicts. I had to make some nontrivial changes in #350 to support a feature for the site launch this week.

@maxatdetroit maxatdetroit linked an issue Jun 24, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements to gov banner

4 participants