Skip to content

Divergences in ui components between Detroit and Core

Jared White edited this page Apr 30, 2022 · 5 revisions

Using this to track a list of differences in the ui-components package between the two repos in the hopes of eventually reconciling them and allowing Detroit to use the Core version of the package without modification.

Components list (aka index.ts)

  • Detroit has an actions/FavoriteButton, Core does not
  • Detroit has a filters helper file, Core does not
  • Detroit commented out the tableSummaries helpers
  • Core has page_components/ApplicationTimeline, Detroit does not
  • Core has page_components/sign-in/FormTerms, Detroit does not
  • Core has page_components/sign-in/ResendConfirmationModal, Detroit does not
  • Detroit has the older sidebar components such as OpenHouseEvent (this was all recently refactored in Core)
  • Detroit doesn't have the new CategoryTable components

Actions

  • Detroit doesn't have the new CSS variables theming changeset for Button yet
  • Detroit's LinkButton has an extra linkProps prop, Core does not

Auth

  • There are a number of differences between Detroit & Core in AuthContext, RequireLogin, & timeout — I'm not sure if that's due to recent updates in Core or an actual divergence

Blocks

  • ActionBlock and FormCard have different heading levels in Detroit vs. Core
  • Detroit's tag styling in ImageCard is different

Forms

  • Many diffs in FieldGroup — I'm not sure if that's due to recent updates in Core or an actual divergence

Global

  • Detroit added accentLight to global/AppearanceTypes
  • Core has all the new Bloom Design Tokens
  • Detroit changed h2 styles in homepage.scss
  • Core has added new Markdown styles
  • Core updated mixins.scss to use the new Design Tokens
  • Big diff in tables.scss — I think it may be due to new Core stuff however
  • Detroit text color change in text.scss
  • Big diff in vendor/AgPagination — I'm not sure if that's due to recent updates in Core or an actual divergence

Headers

  • The Core version of Heading is newer
  • The Detroit version of Hero contains specific visual/content changes which will need to be reconciled/backported
  • The Core version of PageHeader features the 2nd-gen styling updates
  • Differences between Detroit & Core in SiteHeader

Helpers

  • Detroit only has filters, regionNeighborhoodMap, & translationHelpers
  • Detroit has updates in formOptions
  • Differences between Detroit & Core in tableSummaries

Icons

  • Detroit has an extra icon style, Core has new icons and Detroit has different new icons

Locales

  • A variety of issues with locales, including that Detroit has ar and bn files in ui-components rather than in sites/public

Navigation

  • Differences between Detroit & Core in FooterNav, LanguageNav

Overlays

  • Core updates in ProgressNav, Drawer, Overlay, & Modal
  • Core missing class name customization in LoadingOverlay which Detroit has

Page/Listing Components

  • Core only has ApplicationTimeline
  • Core missing class name customization in AdditionalFees
  • Storybook & testing fix in ContentAccordion
  • Differences between Detroit & Core in ListingCard
  • Differences between Detroit & Core in UnitTables
  • Detroit still has the old events components like EventDateSection and OpenHouseEvent
  • Core has an extra watch statement in FormSignIn
  • Core only has FormTerms, ResendConfirmationModal

Sections

  • Detroit class name customizability in GridSection and ListSection
Clone this wiki locally