forked from bloom-housing/bloom
-
Notifications
You must be signed in to change notification settings - Fork 1
Divergences in ui components between Detroit and Core
Jared White edited this page Apr 30, 2022
·
5 revisions
Using this to track a list of differences in the ui-components package between the two repos in the hopes of eventually reconciling them and allowing Detroit to use the Core version of the package without modification.
- Detroit has an
actions/FavoriteButton, Core does not - Detroit has a
filtershelper file, Core does not - Detroit commented out the
tableSummarieshelpers - Core has
page_components/ApplicationTimeline, Detroit does not - Core has
page_components/sign-in/FormTerms, Detroit does not - Core has
page_components/sign-in/ResendConfirmationModal, Detroit does not - Detroit has the older sidebar components such as
OpenHouseEvent(this was all recently refactored in Core) - Detroit doesn't have the new
CategoryTablecomponents
- Detroit doesn't have the new CSS variables theming changeset for
Buttonyet - Detroit's
LinkButtonhas an extralinkPropsprop, Core does not
- There are a number of differences between Detroit & Core in
AuthContext,RequireLogin, &timeout— I'm not sure if that's due to recent updates in Core or an actual divergence
-
ActionBlockandFormCardhave different heading levels in Detroit vs. Core - Detroit's tag styling in
ImageCardis different
- Many diffs in
FieldGroup— I'm not sure if that's due to recent updates in Core or an actual divergence
- Detroit added
accentLighttoglobal/AppearanceTypes - Core has all the new Bloom Design Tokens
- Detroit changed
h2styles inhomepage.scss - Core has added new Markdown styles
- Core updated
mixins.scssto use the new Design Tokens - Big diff in
tables.scss— I think it may be due to new Core stuff however - Detroit text color change in
text.scss - Big diff in
vendor/AgPagination— I'm not sure if that's due to recent updates in Core or an actual divergence
- The Core version of
Headingis newer - The Detroit version of
Herocontains specific visual/content changes which will need to be reconciled/backported - The Core version of
PageHeaderfeatures the 2nd-gen styling updates - Differences between Detroit & Core in
SiteHeader
- Detroit only has
filters,regionNeighborhoodMap, &translationHelpers - Detroit has updates in
formOptions - Differences between Detroit & Core in
tableSummaries
- Detroit has an extra icon style, Core has new icons and Detroit has different new icons
- A variety of issues with locales, including that Detroit has
arandbnfiles in ui-components rather than insites/public
- Differences between Detroit & Core in
FooterNav,LanguageNav
- Core updates in
ProgressNav,Drawer,Overlay, &Modal - Core missing class name customization in
LoadingOverlaywhich Detroit has
- Core only has
ApplicationTimeline - Core missing class name customization in
AdditionalFees - Storybook & testing fix in
ContentAccordion - Differences between Detroit & Core in
ListingCard - Differences between Detroit & Core in
UnitTables - Detroit still has the old events components like
EventDateSectionandOpenHouseEvent - Core has an extra
watchstatement inFormSignIn - Core only has
FormTerms,ResendConfirmationModal
- Detroit class name customizability in
GridSectionandListSection