-
Notifications
You must be signed in to change notification settings - Fork 385
Autogenerate system tables #4492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
@@ -0,0 +1,323 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhtclk let's just modify the script we currently have. There is no need to duplicate the code here such as pulling the binary, reading system-tables.sql
etc.
"build-swagger": "yarn redocly build-docs https://api.clickhouse.cloud/v1 --output build/cloud/manage/api/swagger.html", | ||
"prep-from-local": "bash ./scripts/copy-clickhouse-repo-docs.sh -l $1", | ||
"autogenerate-settings": "bash ./scripts/settings/autogenerate-settings.sh", | ||
"autogenerate-system-tables": "bash ./scripts/system-tables/autogenerate-system-tables.sh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autogenerate-settings
is badly named, but it does both settings and functions, and should do system tables too in the same manner.
- name: Run Auto Generate System Tables | ||
run: yarn autogenerate-system-tables | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We unfortunately can't run it on an action because this documentation also needs to be generated as part of the docs check on ClickHouse/ClickHouse repo. That's why it runs as part of the shell script autogenerate-settings
which is called as part of yarn build
which runs in the Docker container on core repo.
FROM table_columns WHERE comment != '') | ||
FROM table_columns | ||
LIMIT 1 | ||
INTO OUTFILE 'temp-system-table.md' TRUNCATE FORMAT LineAsString No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
|
||
echo "[$SCRIPT_NAME] Auto-generation of system tables documentation completed successfully." | ||
echo "[$SCRIPT_NAME] Processed ${#SYSTEM_TABLES[@]} system tables." | ||
exit 0 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
Summary
Autogenerate System Tables
Checklist