Skip to content

Conversation

mansiruhil
Copy link

@mansiruhil mansiruhil commented Jun 28, 2025

Closes: #302

Describe the changes I've made:

  • Added authentication flow with a provider switch (Google / GitHub).
  • Applied fallbacks to prevent attribute errors for missing user data.
  • Ensured .streamlit/secrets.toml is excluded via .gitignore to protect sensitive API keys.
  • Verified locally with working login and logout flow.

Working Video:

Authentication.-.Profile.1.-.Microsoft.Edge.2025-06-28.20-59-34.mp4

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Member

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a fully working video from login to logout

  • Both platform behaviour should work properly
  • Attach a new video, after all the mentioned changes

No need to close this PR, raise the new PR. You can commit in this PR 👍
If you need any help, connect me on Discord

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoke these changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoke

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it. No Need

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Keep indentation to be 2-spaces
  • Instead of selectbox, use radio buttons for google & github

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need your work in this file
So revoke all changes

@Avdhesh-Varshney Avdhesh-Varshney added the bug Something isn't working label Jul 4, 2025
@Avdhesh-Varshney
Copy link
Member

@mansiruhil Sorry for late response. Yes We can display them as 2 seprate buttons.
User will have choice to select a mode of login. Right?

@Avdhesh-Varshney
Copy link
Member

@mansiruhil Sorry for late response. Yes We can display them as 2 seprate buttons. User will have choice to select a mode of login. Right?

but drop down also applicable for user I think

Yes that'll be applicable. But we should provide the quick options instead of first go for dropdown and select your provider. Right?

@Avdhesh-Varshney
Copy link
Member

Avdhesh-Varshney commented Jul 29, 2025

@mansiruhil Sorry for late response. Yes We can display them as 2 seprate buttons. User will have choice to select a mode of login. Right?

but drop down also applicable for user I think

Yes that'll be applicable. But we should provide the quick options instead of first go for dropdown and select your provider. Right?

can I try the button for google and github auth ?

Yah, I need that. 🙌
But also verify the flow of auth.py file as there might be some changes of displaying the user profile after authentication from github

@Avdhesh-Varshney
Copy link
Member

@mansiruhil plz update your pr so to release this feature and close the task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Flag: Inactive wontfix ❌ This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub Authentication in Addition to Google Login

2 participants