-
Notifications
You must be signed in to change notification settings - Fork 182
Add Google & GitHub Auth with provider switch #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a fully working video from login to logout
- Both platform behaviour should work properly
- Attach a new video, after all the mentioned changes
No need to close this PR, raise the new PR. You can commit in this PR 👍
If you need any help, connect me on Discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revoke these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revoke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it. No Need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Keep indentation to be 2-spaces
- Instead of selectbox, use radio buttons for google & github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need your work in this file
So revoke all changes
@mansiruhil Sorry for late response. Yes We can display them as 2 seprate buttons. |
Yes that'll be applicable. But we should provide the quick options instead of first go for dropdown and select your provider. Right? |
Yah, I need that. 🙌 |
@mansiruhil plz update your pr so to release this feature and close the task |
Closes: #302
Describe the changes I've made:
Working Video:
Authentication.-.Profile.1.-.Microsoft.Edge.2025-06-28.20-59-34.mp4