Skip to content

Removing other username entries from logs #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing other username entries from logs #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions common/djangoapps/track/views/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ def user_track(request):
except ValueError:
pass

try:
data.pop('username')
except KeyError:
pass

context_override = contexts.course_context_from_url(page)
context_override['user_id'] = user_id
context_override['event_source'] = 'browser'
Expand Down Expand Up @@ -128,13 +133,13 @@ def server_track(request, event_type, event, page=None):
return # don't log

try:
username = request.user.username
user_id = request.user.id
except:
username = "anonymous"
user_id = 0

context_override = _get_course_context(page)
context_override.update({
'username': username,
'user_id': user_id,
'event_source': 'server',
'page': page
})
Expand Down Expand Up @@ -170,7 +175,6 @@ def task_track(request_info, task_info, event_type, event, page=None):

context_override = contexts.course_context_from_url(page)
context_override.update({
'username': request_info.get('username', 'unknown'),
'ip': request_info.get('ip', 'unknown'),
'agent': request_info.get('agent', 'unknown'),
'host': request_info.get('host', 'unknown'),
Expand Down