-
Notifications
You must be signed in to change notification settings - Fork 1
Refactoring Unit Tests #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
srjheam
wants to merge
5
commits into
main
Choose a base branch
from
iss30
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e5cc4a7
Added ProjectManager tests and begun improving fakes instantiation
srjheam 139c48c
TestConfig now is the standard to instantiate fakes inside tests
srjheam bde5ee4
Removed FakeProject class
srjheam 056c35d
Removed FakeProjectManager
srjheam 4ca7aea
All business logic factory uses removed from the tests
srjheam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| using Code2Gether_Discord_Bot.Library.Models; | ||
| using Discord; | ||
| using Discord.Commands; | ||
| using System; | ||
|
|
||
| namespace Code2Gether_Discord_Bot.Tests.Fakes | ||
| { | ||
| /// <summary> | ||
| /// Just a logger that logs nothing ¯\_(ツ)_/¯ | ||
| /// </summary> | ||
| class FakeLogger : ILogger | ||
| { | ||
| public void Log(LogSeverity level, string message) { } | ||
|
|
||
| public void Log(LogSeverity level, Exception exception) { } | ||
|
|
||
| public void Log(LogSeverity level, string message, Exception exception) { } | ||
|
|
||
| public void Log(ICommandContext context) { } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| using Code2Gether_Discord_Bot.Library.Models; | ||
| using Discord; | ||
|
|
||
| namespace Code2Gether_Discord_Bot.Tests.Fakes | ||
| { | ||
| /// <summary> | ||
| /// Represents a fake <see cref="Project"/>.This class cannot be inherited. | ||
| /// </summary> | ||
| internal sealed class FakeProject : Project | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="FakeProject"/> class with the specified Id, Name and Author. | ||
| /// </summary> | ||
| /// <param name="id">This instance's Id.</param> | ||
| /// <param name="name">This intance's name.</param> | ||
| /// <param name="author">This instance's Author.</param> | ||
| public FakeProject(int id, string name, IUser author) : base(id, name, author) { } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.