Skip to content

Add internal pages #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Add internal pages #1058

merged 5 commits into from
Feb 24, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Feb 6, 2025

Summary

  • Add internal page markers
  • Load Survey, Banner and Tracking via internal pages

Will affect visual aspect of the product

NO

Test instructions

Important

Test with the SDK build from https://github.com/Codeinwp/themeisle-sdk-main/pull/285

  • Check if there is a regression in Formbricks survey loading.
  • To check debugging in the Console, use URL /wp-admin/edit.php?post_type=feedzy_imports&formbricksDebug=true with the Console already opened
    CleanShot 2025-02-12 at 15 08 02@2x

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/themeisle/issues/1687

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Feb 6, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Feb 6, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the refactor/internal-pages branch 5 times, most recently from 6a0d8ca to 73ad5ad Compare February 10, 2025 13:05
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review February 10, 2025 13:17
@pirate-bot
Copy link
Contributor

pirate-bot commented Feb 10, 2025

Plugin build for e8c010d is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Feb 10, 2025
Copy link
Contributor

@selul selul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soare-Robert-Daniel can we include the number of import jobs, to a limit of 50. i.e if there are more than 50, we show 50.

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit dd2d70e into development Feb 24, 2025
7 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the refactor/internal-pages branch February 24, 2025 10:17
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants