Skip to content

fix: use module import for deps in Block #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Feb 24, 2025

Summary

Using the global variable for dependencies works but the build files can not be properly scanned by WordPress i18n functions.

I switched to import from package.json, like the rest of the scripts.

Will affect visual aspect of the product

NO

Test instructions

  • Check if there is a regression with the build file.

Check before Pull Request is ready:

Closes #978

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Feb 24, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Feb 24, 2025
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Feb 24, 2025
@pirate-bot
Copy link
Contributor

pirate-bot commented Feb 24, 2025

Plugin build for a6a2ba8 is ready 🛎️!

Using the global variable for dependencies works but the build files can not be properly scanned by WordPress i18n functions.
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 856e0c2 into development Feb 24, 2025
9 of 10 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/js-imports branch February 24, 2025 10:21
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants