refactor: use the new hooks for Black Friday #1069

Soare-Robert-Daniel · 2025-05-07T11:54:27Z

Summary

Use the Black Friday hooks from https://github.com/Codeinwp/themeisle-sdk-main/pull/295

Will affect visual aspect of the product

YES

Screenshots

Test instructions

USE THIS SDK VERSION as PLUGIN
Alter the date to fall into the Black Friday sales period.

You can use this hook to alternate it:

add_filter(
	'themeisle_sdk_current_date',
	function() {
		return new DateTime( '2025-11-26' );
	}
);

Check before Pull Request is ready:

I have written a test and included it in this PR
I have run all tests and they pass
The code passes when running the PHP CodeSniffer
Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
Security and Sanitization requirements have been followed
[ x I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes https://github.com/Codeinwp/ideas/issues/59

selul · 2025-05-12T13:03:45Z

img/black-friday.png

I think we can remove this no?

selul · 2025-05-12T13:04:12Z

includes/admin/feedzy-rss-feeds-admin.php

-				if ( self::plan_category( $license_data ) <= 1 ) {
-					do_action( 'themeisle_sdk_load_banner', 'feedzy' );
-				}
+			if ( in_array( $page_slug, array( 'imports', 'categories', 'settings' ) ) ) {


I don't think we need this anymore no, I mean calling twice this?

The notice runs only once from the product that is loading.

If we have Otter with Feedzy, and Otter is the one that adds the last hook, the Otter message will be used for Global and product pages.

In the internal pages, we add the hook so that it can render on top of each other.

If we add the hook only on internal pages, then there is no conflict and on the non-product pages, the default message will be displayed.

selul · 2025-05-12T13:04:21Z

includes/admin/feedzy-rss-feeds-admin.php

@@ -77,6 +77,8 @@ function( $data, $page_slug ) {
 			);
 		}

+		apply_filters( 'themeisle_sdk_blackfriday_data', array( $this, 'set_black_friday_data' ) );


it should be add_filter, no?

selul · 2025-05-12T13:04:33Z

includes/admin/feedzy-rss-feeds-admin.php

+		$discount      = '40%';
+
+		if ( feedzy_is_pro() ) {
+			$product_label = __( 'Feedzy RSS Feeds Pro', 'feedzy-rss-feeds' );


Let's use Feedzy PRO

selul · 2025-05-12T13:04:45Z

includes/admin/feedzy-rss-feeds-admin.php

+	 * @return array
+	 */
+	public function set_black_friday_data( $config ) {
+		$product_label = __( 'Feedzy RSS Feeds', 'feedzy-rss-feeds' );


Let's use Feedzy

selul · 2025-05-12T13:04:57Z

includes/admin/feedzy-rss-feeds-admin.php

+	 */
+	public function set_black_friday_data( $config ) {
+		$product_label = __( 'Feedzy RSS Feeds', 'feedzy-rss-feeds' );
+		$discount      = '40%';


Let's use 70%

selul · 2025-05-12T13:05:09Z

includes/admin/feedzy-rss-feeds-admin.php

+
+		if ( feedzy_is_pro() ) {
+			$product_label = __( 'Feedzy RSS Feeds Pro', 'feedzy-rss-feeds' );
+			$discount = '50%';


let's use 30%

Let's use for pro this message Get 30% off when you upgrade your Feedzy Pro plan or renew early.

selul · 2025-05-12T13:19:23Z

includes/admin/feedzy-rss-feeds-admin.php

+		$config['url']    = add_query_arg( array(
+			'utm_plugin' => feedzy_is_pro() ? 'feedzy-pro' : 'feedzy-rss-feeds',
+			'utm_plan'   => self::plan_category( $license_data ),
+		), $config['base_url'] );


Let's use here

add_query_arg( [ 'utm_term' => feedzy_is_pro() ? 'plan-' . apply_filters( 'product_feedzy_license_plan', 0 ) : 'free' ], tsdk_translate_link( tsdk_utmify( 'https://themeisle.com/plugins/feedzy-rss-feeds/blackfriday', 'bfcm', 'feedzy' ) ) );

@Soare-Robert-Daniel lets also include the licensekey as lkey using product_feedzy_license_key

The URL will look this: https://themeisle.com/plugins/feedzy-rss-feeds/blackfriday?utm_source=wpadmin&utm_medium=feedzy&utm_campaign=bfcm&utm_content=feedzy-rss-feedsblackfriday&utm_term=plan-3&lkey=d5498f84bc277aa7043bfc86f185c798

Since this is per user, should we restrict the lkey only to users who have the capabilities to manage plugins? This is not to leak the key to editors, etc.

good point, we can. Lets do this in the SDK, by using remove_query_arg if the url contains lkey and the user does not have the right permision.

With this we have available the $current_product, should we use this to get the plan (priceID) and the license key directly from the SDK using the product_<slug> filters instead of having it in each product?

nope, I think is good as it is.

pirate-bot · 2025-05-12T14:04:05Z

Plugin build for 746b152 is ready 🛎️!

Download build

Note

You can preview the changes in the Playground

selul · 2025-05-13T07:37:53Z

includes/admin/feedzy-rss-feeds-admin.php

+			$discount      = '30%';
+
+			// translators: %1$s - discount, %2$s - product label.
+			$config['message'] = sprintf( __( 'Get <strong>%1$s off</strong> when you upgrade your <strong>%2$s</strong> plan or renew early.', 'feedzy-rss-feeds' ), $discount, $product_label );


@Soare-Robert-Daniel we need also to use placeholders for html tags, no need to send them for translation.

selul · 2025-05-15T11:32:33Z

img/black-friday.png

@Soare-Robert-Daniel I guess we can delete this no?

Soare-Robert-Daniel self-assigned this May 12, 2025

Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label May 12, 2025

Soare-Robert-Daniel added 6 commits May 12, 2025 16:29

refactor: use the new hooks for Black Friday

f8e7222

chore: update hooks

ba3fece

refactor: use single hook

7344d3b

fix: styling with the black friday notice in settings

428aad3

fix: phpcs

18975fa

chore: add WP Playground preview link

de108e4

Soare-Robert-Daniel force-pushed the refactor/black-friday branch from e962061 to de108e4 Compare May 12, 2025 13:29

Soare-Robert-Daniel marked this pull request as ready for review May 12, 2025 13:30

selul requested changes May 12, 2025

View reviewed changes

refactor: changes

34d6e7b

pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label May 12, 2025

Soare-Robert-Daniel added 2 commits May 12, 2025 17:58

chore: add lkey

565d446

chore: function usage

fae13b5

Soare-Robert-Daniel mentioned this pull request May 12, 2025

refactor: register Black Friday via new SDK hooks Codeinwp/otter-blocks#2576

Open

9 tasks

selul requested changes May 13, 2025

View reviewed changes

refactor: use configs array

ea49247

Soare-Robert-Daniel force-pushed the refactor/black-friday branch from 074f243 to ea49247 Compare May 13, 2025 08:54

Soare-Robert-Daniel added 6 commits May 13, 2025 12:25

refactor: payload data

0aa1594

refactor: simplify

72d62a5

chore(actions): env for preview link

9df1b4b

fix: artifacts visibility

5db640b

chore: update labels & link

58607fd

chore: empty license key utm param on deactivated license

6deca1b

Soare-Robert-Daniel requested a review from selul May 15, 2025 11:31

selul approved these changes May 15, 2025

View reviewed changes

img/black-friday.png Outdated

Copy link

Contributor

selul May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Soare-Robert-Daniel I guess we can delete this no?

Soare-Robert-Daniel reacted with eyes emoji

chore: delete image

746b152

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: use the new hooks for Black Friday #1069

refactor: use the new hooks for Black Friday #1069

Soare-Robert-Daniel commented May 7, 2025 •

edited

Loading

selul May 12, 2025

selul May 12, 2025

Soare-Robert-Daniel May 12, 2025

selul May 12, 2025

selul May 12, 2025

selul May 12, 2025

selul May 12, 2025

selul May 12, 2025

selul May 12, 2025

selul May 12, 2025

selul May 12, 2025

Soare-Robert-Daniel May 12, 2025

selul May 13, 2025

Soare-Robert-Daniel May 13, 2025

selul May 13, 2025

pirate-bot commented May 12, 2025 •

edited

Loading

selul May 13, 2025

selul May 15, 2025

refactor: use the new hooks for Black Friday #1069

Are you sure you want to change the base?

refactor: use the new hooks for Black Friday #1069

Conversation

Soare-Robert-Daniel commented May 7, 2025 • edited Loading

Summary

Will affect visual aspect of the product

Screenshots

Test instructions

Check before Pull Request is ready:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pirate-bot commented May 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Soare-Robert-Daniel commented May 7, 2025 •

edited

Loading

pirate-bot commented May 12, 2025 •

edited

Loading