-
Notifications
You must be signed in to change notification settings - Fork 12
feat: improve the lazy loading tab #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7dae879
to
c74dbfc
Compare
@selul @ineagu, here is how it looks for the Formbricks survey integration with the modal notice when a user tries to disable an important lazy load option. Issue Reference: https://github.com/Codeinwp/optimole-service/issues/1551 2025-09-22_15-38-15.mp4 |
@Soare-Robert-Daniel can't we embed somehow the survey in the popup? if not it's fine
What do you think? |
|
||
// // If the image is between the first images we add the fetchpriority attribute to improve the LCP. | ||
if ( | ||
$this->settings->is_lazyload_type_fixed() && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should call this if viewport is enabled + optimization is not done for the current url || viewport is disabled.
I tried to use the embedded form of Formbricks, but it's pretty wacky. I do not recommend. ![]()
I see Gravity Forms has a nice feature in which we can prefill with just the URL: https://docs.gravityforms.com/allow-field-to-be-populated-dynamically/ |
okay, we can keep it as you are doing now. |
@ineagu, here are the interactions with the new changes (including the notice with prefilling) 2025-09-23_16-39-37.mp4For the skip lazy load number input selector, I had to put it separately from the text since the embedding was creating a weird focus issue. ![]() |
36042ba
to
a2bb2ba
Compare
Fixed
Yes. This is how the Gutenberg component behaves, which can also be verified in https://wordpress.github.io/gutenberg/?path=/docs/components-modal--docs, like in the screenshot below: ![]() |
e0a0054
to
142f63b
Compare
I added the Lear Mode link for https://github.com/Codeinwp/optimole-service/issues/1515 as part of the toggle description. ![]() |
from what I've tested, it's working well |
All Submissions:
Changes proposed in this Pull Request:
Reorganize the lazy load and scaling settings:
viewport|fixed
optionCurrent status
Closes https://github.com/Codeinwp/optimole-service/issues/1559
How to test the changes in this Pull Request:
Other information: