feat: helper text for 'visits' metric #966
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds helper text and tooltip functionality to clarify the 'visits' metric in the Optimole dashboard. It provides users with better understanding of how visits are counted and when their quota resets.
- Adds tooltip with explanation of what constitutes a visit and renewal date information
- Displays renewal date next to the usage percentage
- Introduces new translatable strings for the tooltip content and renewal date format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inc/admin.php | Adds new translatable strings for tooltip title, description, and renewal date format |
| assets/src/dashboard/parts/connected/dashboard/index.js | Implements tooltip UI component with visit explanation and adds renewal date display |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+145
to
+154
| const renewalDate = useMemo( () => { | ||
| const timestamp = userData.renews_on; | ||
|
|
||
| if ( ! timestamp ) { | ||
| return 'N/A'; | ||
| } | ||
|
|
||
| const date = new Date( timestamp * 1000 ); | ||
| return date.toLocaleDateString( undefined, { year: 'numeric', month: 'short', day: 'numeric' }); | ||
| }, [ userData.renews_on ]); |
There was a problem hiding this comment.
The hardcoded 'N/A' fallback should be a translatable string since this text will be displayed to users and the codebase appears to use internationalization throughout.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Added clarity for ‘visits’ metric with helper text and renewal info
Closes https://github.com/Codeinwp/optimole-service/issues/1544
Other information: