First practice with adapter and ports #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddenysov
reviewed
Aug 26, 2021
| public function __invoke(Request $request): JsonResponse | ||
| { | ||
| return new JsonResponse( | ||
| $this->queryBus->__invoke() |
There was a problem hiding this comment.
Just interesting. Why not $this->queryBus() ?
There was a problem hiding this comment.
I think both of them it's right since in my current job using the __invoke to be more explicit that is the reason that I used here, but i think it's ok use as function, maybe i don't have any particular reason, only by the definition on my teamwork. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the first practice with hexagonal architect please if you have any comment don´t hesitate in making me know it