-
Notifications
You must be signed in to change notification settings - Fork 611
Add per db metrics #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add per db metrics #4183
Conversation
Some notes on this PR:
|
@@ -2165,6 +2170,12 @@ spec: | |||
type: string | |||
type: array | |||
type: object | |||
perDBMetricTargets: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 IIUC, this and customQueries
only make sense at/on Postgres. Is there a way to arrange structs so the PGAdmin API doesn't have these fields? Not a blocker; v1beta1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to make any too big changes with the spec, but I wonder if the pgadmin and postgrescluster versions will diverge even more (or if we'll eventually want to slice up instrumentation by target-type, eg., postgres-instrumentation, pgbouncer-instrumentation, pgadmin-instrumentation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah good point... Probably makes sense to at least have a pgadmin-instrumentation and a postgrescluster-instrumentation and then pick and choose which structs make sense in each
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
No per-db metrics
What is the new behavior (if this is a feature change)?
Breaking change (fix or feature that would cause existing functionality to change)
Add per-db metrics (based on pgMonitor v5.2.1)
Allow per-db custom metrics
Other Information:
Issues: [PGO-21]