Skip to content

Action Service #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Action Service #1914

wants to merge 4 commits into from

Conversation

SOHAMPAL23
Copy link
Contributor

Pull Requests Requirements

  • Clearly describe what changes have been made in the integration tests. Include information about the specific functionality being tested and any new tests that have been added.

Testing Scope:

  • Specify which components or services have been covered in the integration tests.

Summary

This PR introduces comprehensive Spring JUnit tests for the Action module, complete with a corresponding DBUnit XML dataset. It ensures full CRUD coverage, robust edge case handling, and valid integration with the service and DAO layers.

Related Issue

#1913

Other

[Add any additional information or notes here]

@AfterEach
public void cleanUp() throws Exception {
try (Connection conn = dataSource.getConnection(); Statement stmt = conn.createStatement()) {
stmt.execute("TRUNCATE TABLE action RESTART IDENTITY CASCADE");
Copy link
Collaborator

@mozzy11 mozzy11 Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use the existing cleanRowsInCurrentConnection util to clean the tables ??

@mozzy11
Copy link
Collaborator

mozzy11 commented Apr 15, 2025

@SOHAMPAL23 can you fix the formatting issue ??

@SOHAMPAL23
Copy link
Contributor Author

@mozzy11 Yeah working on it

@adityadeshlahre
Copy link
Contributor

@mozzy11 Yeah working on it

RUN mvn spotless:apply in main project dir and commit the changes

@mozzy11
Copy link
Collaborator

mozzy11 commented Apr 15, 2025

Thanks @SOHAMPAL23 .
Can you ensure the tests run fine in your local enviroment ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants