Switched from checkboxes to Radio buttons in Organization Management #2043
+27
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-273
to
+271
| setSelectedRowIds([...selectedRowIds, row.id]); | ||
| } | ||
| }} | ||
| /> | ||
| <TableCell key={cell.id} style={{ textAlign: "center" }}> | ||
| <RadioButton | ||
| id={`radio-${row.id}`} | ||
| name="organization-radio-group" | ||
| checked={selectedRowIds.includes(row.id)} | ||
| onChange={() => { | ||
| setSelectedRowIds([row.id]); | ||
| const isActiveCell = row.cells.find((cell) => | ||
| cell.id.endsWith(":active"), | ||
| ); | ||
| let isActiveValue = ""; | ||
| if (isActiveCell) { | ||
| isActiveValue = isActiveCell.value; | ||
| } | ||
| setDeactivateButton(isActiveValue !== "Y"); | ||
| }} | ||
| labelText="" | ||
| style={{ margin: "0 auto" }} | ||
| /> | ||
| </TableCell> |
There was a problem hiding this comment.
so while i was rewriting this page initally i thought why there is now whole list select button when we can select and delete multiple orgs using the API. Hence that was the purpose of adding MultiSelect Check Boxes just because API supports it.
There was a problem hiding this comment.
Ohhh so basing on the backend implementation, we need to keep them as checkboxes??
There was a problem hiding this comment.
Ohhh makes sense @adityadeshlahre. I guess maybe @mozzy11 can tell us what to do.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
Screenshots
[Add relevant screenshots here if applicable]
Screencast from 2025-06-05 13-28-03.webm
Related Issue
[Add a link to the related issue or mention it here if applicable]
closes #2038
Other
[Add any additional information or notes here]