Skip to content

[Fix] require hotkey to be pressed once #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Fix] require hotkey to be pressed once #75

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e80839f
[FIX]: require hotkey to be pressed once
Domi0503 Aug 28, 2025
0bfa494
revert changes to run configuration
Domi0503 Aug 28, 2025
3a5f86e
revert changes to run configuration
Domi0503 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion target/desktop/src/main/kotlin/app/cleanmeter/target/desktop/KeyboardHook.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,15 @@ internal object KeyboardManager {
val isCtrl = nativeEvent.modifiers.and(NativeKeyEvent.CTRL_MASK) > 0
val isAlt = nativeEvent.modifiers.and(NativeKeyEvent.VC_ALT) > 0

if (!isCtrl && !isAlt) return
if (!isCtrl || !isAlt) return

val event = when (nativeEvent.keyCode) {
NativeKeyEvent.VC_F10 -> KeyboardEvent.ToggleOverlay
NativeKeyEvent.VC_F11 -> KeyboardEvent.ToggleRecording
else -> null
}
event?.let { _channel.trySend(it) }
event?.let { _channel.trySend(it) }
Copy link
Owner

@Danil0v3s Danil0v3s Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's not working because the channel initialisation is wrong or the other side collecting it is converting to a flow with wrong parameters?

Copy link
Owner

@Danil0v3s Danil0v3s Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this answer from Claude

https://claude.ai/share/5fc461d3-d2e2-4753-a706-9ec03b67ddb9

Maybe option 2 is a better alternative?

Copy link
Author

@Domi0503 Domi0503 Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did try the first suggestion with an unlimited channel already, but it didn't work and also seems like a dirty fix.

The second one looks surprisingly good. I will try another approach and update this PR once done. I don't like duplicating this line either 😂

}
})
} catch (e: Throwable) {
Expand Down