-
Notifications
You must be signed in to change notification settings - Fork 312
Implement Failed Test Replay #9214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (312.2 µs) : 290, 334
. : milestone, 312,
basic (274.252 µs) : 268, 281
. : milestone, 274,
loop (8.96 ms) : 8956, 8965
. : milestone, 8960,
section candidate
noprobe (318.064 µs) : 289, 347
. : milestone, 318,
basic (276.757 µs) : 271, 283
. : milestone, 277,
loop (8.964 ms) : 8959, 8968
. : milestone, 8964,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~ffda9b3272, baseline=1.53.0-SNAPSHOT~8daf35212f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048589
Total [baseline] (10.653 s) : 0, 10652553
Agent [candidate] (1.058 s) : 0, 1057935
Total [candidate] (10.695 s) : 0, 10695467
section appsec
Agent [baseline] (1.219 s) : 0, 1218768
Total [baseline] (10.717 s) : 0, 10716728
Agent [candidate] (1.223 s) : 0, 1223211
Total [candidate] (10.788 s) : 0, 10787623
section iast
Agent [baseline] (1.18 s) : 0, 1180300
Total [baseline] (10.992 s) : 0, 10992392
Agent [candidate] (1.177 s) : 0, 1177192
Total [candidate] (10.965 s) : 0, 10964800
section profiling
Agent [baseline] (1.197 s) : 0, 1196617
Total [baseline] (10.875 s) : 0, 10874789
Agent [candidate] (1.206 s) : 0, 1205591
Total [candidate] (11.0 s) : 0, 10999810
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~ffda9b3272, baseline=1.53.0-SNAPSHOT~8daf35212f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (733.651 ms) : 0, 733651
BytebuddyAgent [candidate] (740.228 ms) : 0, 740228
GlobalTracer [baseline] (242.459 ms) : 0, 242459
GlobalTracer [candidate] (243.462 ms) : 0, 243462
AppSec [baseline] (30.113 ms) : 0, 30113
AppSec [candidate] (30.405 ms) : 0, 30405
Debugger [baseline] (6.057 ms) : 0, 6057
Debugger [candidate] (6.117 ms) : 0, 6117
Remote Config [baseline] (680.623 µs) : 0, 681
Remote Config [candidate] (680.133 µs) : 0, 680
Telemetry [baseline] (13.11 ms) : 0, 13110
Telemetry [candidate] (14.32 ms) : 0, 14320
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (753.112 ms) : 0, 753112
BytebuddyAgent [candidate] (755.487 ms) : 0, 755487
GlobalTracer [baseline] (234.336 ms) : 0, 234336
GlobalTracer [candidate] (235.388 ms) : 0, 235388
AppSec [baseline] (169.735 ms) : 0, 169735
AppSec [candidate] (168.227 ms) : 0, 168227
Debugger [baseline] (6.421 ms) : 0, 6421
Debugger [candidate] (6.513 ms) : 0, 6513
Remote Config [baseline] (657.309 µs) : 0, 657
Remote Config [candidate] (640.86 µs) : 0, 641
Telemetry [baseline] (8.414 ms) : 0, 8414
Telemetry [candidate] (10.777 ms) : 0, 10777
IAST [baseline] (23.662 ms) : 0, 23662
IAST [candidate] (23.584 ms) : 0, 23584
section iast
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.564 ms) : 0, 1564
BytebuddyAgent [baseline] (851.469 ms) : 0, 851469
BytebuddyAgent [candidate] (849.347 ms) : 0, 849347
GlobalTracer [baseline] (233.122 ms) : 0, 233122
GlobalTracer [candidate] (232.829 ms) : 0, 232829
AppSec [baseline] (28.752 ms) : 0, 28752
AppSec [candidate] (28.998 ms) : 0, 28998
Debugger [baseline] (5.833 ms) : 0, 5833
Debugger [candidate] (6.642 ms) : 0, 6642
Remote Config [baseline] (623.576 µs) : 0, 624
Remote Config [candidate] (608.938 µs) : 0, 609
Telemetry [baseline] (8.614 ms) : 0, 8614
Telemetry [candidate] (8.444 ms) : 0, 8444
IAST [baseline] (29.276 ms) : 0, 29276
IAST [candidate] (27.693 ms) : 0, 27693
section profiling
crashtracking [baseline] (1.408 ms) : 0, 1408
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (762.29 ms) : 0, 762290
BytebuddyAgent [candidate] (767.212 ms) : 0, 767212
GlobalTracer [baseline] (222.035 ms) : 0, 222035
GlobalTracer [candidate] (224.186 ms) : 0, 224186
AppSec [baseline] (30.165 ms) : 0, 30165
AppSec [candidate] (30.605 ms) : 0, 30605
Debugger [baseline] (6.234 ms) : 0, 6234
Debugger [candidate] (6.38 ms) : 0, 6380
Remote Config [baseline] (723.918 µs) : 0, 724
Remote Config [candidate] (734.518 µs) : 0, 735
Telemetry [baseline] (16.437 ms) : 0, 16437
Telemetry [candidate] (16.365 ms) : 0, 16365
ProfilingAgent [baseline] (107.719 ms) : 0, 107719
ProfilingAgent [candidate] (108.644 ms) : 0, 108644
Profiling [baseline] (108.364 ms) : 0, 108364
Profiling [candidate] (109.3 ms) : 0, 109300
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~ffda9b3272, baseline=1.53.0-SNAPSHOT~8daf35212f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052723
Total [baseline] (8.608 s) : 0, 8608212
Agent [candidate] (1.045 s) : 0, 1045309
Total [candidate] (8.562 s) : 0, 8562183
section iast
Agent [baseline] (1.182 s) : 0, 1182041
Total [baseline] (9.277 s) : 0, 9277167
Agent [candidate] (1.178 s) : 0, 1178106
Total [candidate] (9.293 s) : 0, 9292751
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~ffda9b3272, baseline=1.53.0-SNAPSHOT~8daf35212f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (737.973 ms) : 0, 737973
BytebuddyAgent [candidate] (731.856 ms) : 0, 731856
GlobalTracer [baseline] (243.556 ms) : 0, 243556
GlobalTracer [candidate] (242.088 ms) : 0, 242088
AppSec [baseline] (30.393 ms) : 0, 30393
AppSec [candidate] (30.11 ms) : 0, 30110
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.039 ms) : 0, 6039
Remote Config [baseline] (670.042 µs) : 0, 670
Remote Config [candidate] (663.053 µs) : 0, 663
Telemetry [baseline] (11.525 ms) : 0, 11525
Telemetry [candidate] (12.174 ms) : 0, 12174
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (853.161 ms) : 0, 853161
BytebuddyAgent [candidate] (850.483 ms) : 0, 850483
GlobalTracer [baseline] (233.633 ms) : 0, 233633
GlobalTracer [candidate] (232.753 ms) : 0, 232753
AppSec [baseline] (26.873 ms) : 0, 26873
AppSec [candidate] (29.186 ms) : 0, 29186
Debugger [baseline] (7.56 ms) : 0, 7560
Debugger [candidate] (6.626 ms) : 0, 6626
Remote Config [baseline] (589.76 µs) : 0, 590
Remote Config [candidate] (594.488 µs) : 0, 594
Telemetry [baseline] (8.325 ms) : 0, 8325
Telemetry [candidate] (8.399 ms) : 0, 8399
IAST [baseline] (29.376 ms) : 0, 29376
IAST [candidate] (27.57 ms) : 0, 27570
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ffda9b3272, baseline=1.53.0-SNAPSHOT~8daf35212f
dateFormat X
axisFormat %s
section baseline
no_agent (4.312 ms) : 4263, 4362
. : milestone, 4312,
iast (9.466 ms) : 9312, 9620
. : milestone, 9466,
iast_FULL (14.302 ms) : 14015, 14588
. : milestone, 14302,
iast_GLOBAL (10.656 ms) : 10459, 10854
. : milestone, 10656,
profiling (8.733 ms) : 8599, 8867
. : milestone, 8733,
tracing (7.635 ms) : 7526, 7744
. : milestone, 7635,
section candidate
no_agent (4.335 ms) : 4282, 4387
. : milestone, 4335,
iast (9.291 ms) : 9143, 9440
. : milestone, 9291,
iast_FULL (14.23 ms) : 13946, 14514
. : milestone, 14230,
iast_GLOBAL (10.328 ms) : 10126, 10530
. : milestone, 10328,
profiling (8.997 ms) : 8858, 9137
. : milestone, 8997,
tracing (7.7 ms) : 7584, 7817
. : milestone, 7700,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ffda9b3272, baseline=1.53.0-SNAPSHOT~8daf35212f
dateFormat X
axisFormat %s
section baseline
no_agent (36.698 ms) : 36400, 36996
. : milestone, 36698,
appsec (47.242 ms) : 46812, 47672
. : milestone, 47242,
code_origins (45.973 ms) : 45564, 46382
. : milestone, 45973,
iast (45.393 ms) : 44990, 45796
. : milestone, 45393,
profiling (46.763 ms) : 46314, 47212
. : milestone, 46763,
tracing (43.024 ms) : 42674, 43373
. : milestone, 43024,
section candidate
no_agent (36.887 ms) : 36593, 37181
. : milestone, 36887,
appsec (46.694 ms) : 46277, 47112
. : milestone, 46694,
code_origins (45.359 ms) : 44960, 45759
. : milestone, 45359,
iast (45.749 ms) : 45352, 46146
. : milestone, 45749,
profiling (48.9 ms) : 48434, 49366
. : milestone, 48900,
tracing (44.718 ms) : 44311, 45124
. : milestone, 44718,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ffda9b3272, baseline=1.53.0-SNAPSHOT~8daf35212f
dateFormat X
axisFormat %s
section baseline
no_agent (1.491 ms) : 1479, 1502
. : milestone, 1491,
appsec (2.727 ms) : 2646, 2809
. : milestone, 2727,
iast (2.552 ms) : 2453, 2651
. : milestone, 2552,
iast_GLOBAL (2.602 ms) : 2504, 2701
. : milestone, 2602,
profiling (2.362 ms) : 2279, 2444
. : milestone, 2362,
tracing (2.353 ms) : 2272, 2433
. : milestone, 2353,
section candidate
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (4.095 ms) : 3846, 4345
. : milestone, 4095,
iast (2.548 ms) : 2450, 2646
. : milestone, 2548,
iast_GLOBAL (2.596 ms) : 2497, 2694
. : milestone, 2596,
profiling (2.396 ms) : 2311, 2480
. : milestone, 2396,
tracing (2.349 ms) : 2268, 2430
. : milestone, 2349,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ffda9b3272, baseline=1.53.0-SNAPSHOT~8daf35212f
dateFormat X
axisFormat %s
section baseline
no_agent (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
appsec (14.519 s) : 14519000, 14519000
. : milestone, 14519000,
iast (17.613 s) : 17613000, 17613000
. : milestone, 17613000,
iast_GLOBAL (17.765 s) : 17765000, 17765000
. : milestone, 17765000,
profiling (14.783 s) : 14783000, 14783000
. : milestone, 14783000,
tracing (14.646 s) : 14646000, 14646000
. : milestone, 14646000,
section candidate
no_agent (14.309 s) : 14309000, 14309000
. : milestone, 14309000,
appsec (14.175 s) : 14175000, 14175000
. : milestone, 14175000,
iast (17.618 s) : 17618000, 17618000
. : milestone, 17618000,
iast_GLOBAL (17.427 s) : 17427000, 17427000
. : milestone, 17427000,
profiling (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
tracing (14.519 s) : 14519000, 14519000
. : milestone, 14519000,
|
Code coverage: total 57.32%, base diff -0.03%, patch 45.45% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: ffda9b3 | Docs | Was this helpful? Give us feedback! |
What Does This Do
Implements Test Optimization's Failed Test Replay using Live Debugger's Exception Replay. When the feature is enabled and a test is retried due to Auto Test Retries, Exception Replay's logic will create a probe for the exception thrown (in the case of the test probably an assertion error, but not limited to it). When the test is retried, the probe captures debugging information if the exception is encountered again, creating a snapshot of the variables. If the snapshot is captured, it is send as a log to Datadog. The following modifications were made to Exception Replay's original implementation:
Config
. The enabling of Exception Replay now checks for either the property to be marked as enabled or Failed Test Replay being marked as active. This works due to CiVisibility's system being initialized before Live Debugger's.DefaultExceptionDebugger
was modified to support Failed Test Replay:product
field to snapshots, populated withtest_optimization
if Failed Test Replay was marked as active. This allows us to have the option of not billing customers for logs generated by the product.DD_CIVISIBILITY_AGENTLESS_ENABLED
is set, Live Debugger's logic for Exception Replay will use the logs API instead of the agent's.DebuggerSink
on test suite end, to avoid unsent snapshots.Additional changes:
BackendApiFactory.Intake
to a standaloneIntake
, given that it is useful in order to compute agentless mode URLs.failed_test_replay
in test frameworks that support Auto Test Retries.di_enabled
to the Settings response and telemetry.Validation:
MavenSmokeTest
now has an additional test for Failed Test Replay, validating the feature when build system instrumentation is present.JUnitConsoleSmokeTest
to validate the feature in headless mode. This test should ensure that the ordering dependency between CiVisibility's system and Live Debugger's is always accounted for.Motivation
Test Optimization wants to improve the support for Failed Test Replay, implementing it in additional languages apart from JS.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-2242