-
Notifications
You must be signed in to change notification settings - Fork 311
Update GHA workflows to use dd-octo-sts to sign commits #9365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~013f3af04d, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049280
Total [baseline] (8.594 s) : 0, 8594242
Agent [candidate] (1.042 s) : 0, 1042186
Total [candidate] (8.593 s) : 0, 8592951
section iast
Agent [baseline] (1.175 s) : 0, 1174934
Total [baseline] (9.282 s) : 0, 9281980
Agent [candidate] (1.184 s) : 0, 1184224
Total [candidate] (9.32 s) : 0, 9320306
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~013f3af04d, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.414 ms) : 0, 1414
BytebuddyAgent [baseline] (735.092 ms) : 0, 735092
BytebuddyAgent [candidate] (730.2 ms) : 0, 730200
GlobalTracer [baseline] (242.658 ms) : 0, 242658
GlobalTracer [candidate] (241.697 ms) : 0, 241697
AppSec [baseline] (30.347 ms) : 0, 30347
AppSec [candidate] (29.997 ms) : 0, 29997
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.0 ms) : 0, 6000
Remote Config [baseline] (655.377 µs) : 0, 655
Remote Config [candidate] (653.985 µs) : 0, 654
Telemetry [baseline] (12.066 ms) : 0, 12066
Telemetry [candidate] (11.343 ms) : 0, 11343
section iast
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (848.33 ms) : 0, 848330
BytebuddyAgent [candidate] (855.729 ms) : 0, 855729
GlobalTracer [baseline] (233.169 ms) : 0, 233169
GlobalTracer [candidate] (233.573 ms) : 0, 233573
AppSec [baseline] (28.802 ms) : 0, 28802
AppSec [candidate] (26.757 ms) : 0, 26757
Debugger [baseline] (7.398 ms) : 0, 7398
Debugger [candidate] (7.421 ms) : 0, 7421
Remote Config [baseline] (579.054 µs) : 0, 579
Remote Config [candidate] (584.871 µs) : 0, 585
Telemetry [baseline] (8.32 ms) : 0, 8320
Telemetry [candidate] (8.221 ms) : 0, 8221
IAST [baseline] (25.933 ms) : 0, 25933
IAST [candidate] (29.536 ms) : 0, 29536
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~013f3af04d, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045513
Total [baseline] (10.708 s) : 0, 10708171
Agent [candidate] (1.051 s) : 0, 1050589
Total [candidate] (10.684 s) : 0, 10683772
section appsec
Agent [baseline] (1.235 s) : 0, 1234650
Total [baseline] (10.798 s) : 0, 10797507
Agent [candidate] (1.219 s) : 0, 1219214
Total [candidate] (10.819 s) : 0, 10818758
section iast
Agent [baseline] (1.176 s) : 0, 1175990
Total [baseline] (10.994 s) : 0, 10993941
Agent [candidate] (1.182 s) : 0, 1181966
Total [candidate] (10.893 s) : 0, 10892691
section profiling
Agent [baseline] (1.192 s) : 0, 1192028
Total [baseline] (10.917 s) : 0, 10917119
Agent [candidate] (1.193 s) : 0, 1192738
Total [candidate] (10.9 s) : 0, 10899762
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~013f3af04d, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (730.365 ms) : 0, 730365
BytebuddyAgent [candidate] (736.961 ms) : 0, 736961
GlobalTracer [baseline] (241.867 ms) : 0, 241867
GlobalTracer [candidate] (242.448 ms) : 0, 242448
AppSec [baseline] (29.987 ms) : 0, 29987
AppSec [candidate] (29.959 ms) : 0, 29959
Debugger [baseline] (6.002 ms) : 0, 6002
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (647.578 µs) : 0, 648
Remote Config [candidate] (647.878 µs) : 0, 648
Telemetry [baseline] (14.257 ms) : 0, 14257
Telemetry [candidate] (12.001 ms) : 0, 12001
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (763.843 ms) : 0, 763843
BytebuddyAgent [candidate] (753.218 ms) : 0, 753218
GlobalTracer [baseline] (237.816 ms) : 0, 237816
GlobalTracer [candidate] (234.569 ms) : 0, 234569
AppSec [baseline] (171.699 ms) : 0, 171699
AppSec [candidate] (168.623 ms) : 0, 168623
Debugger [baseline] (5.695 ms) : 0, 5695
Debugger [candidate] (7.143 ms) : 0, 7143
Remote Config [baseline] (623.297 µs) : 0, 623
Remote Config [candidate] (615.836 µs) : 0, 616
Telemetry [baseline] (8.395 ms) : 0, 8395
Telemetry [candidate] (9.069 ms) : 0, 9069
IAST [baseline] (23.896 ms) : 0, 23896
IAST [candidate] (23.574 ms) : 0, 23574
section iast
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (848.768 ms) : 0, 848768
BytebuddyAgent [candidate] (854.468 ms) : 0, 854468
GlobalTracer [baseline] (232.537 ms) : 0, 232537
GlobalTracer [candidate] (233.73 ms) : 0, 233730
AppSec [baseline] (26.783 ms) : 0, 26783
AppSec [candidate] (27.435 ms) : 0, 27435
Debugger [baseline] (6.652 ms) : 0, 6652
Debugger [candidate] (8.188 ms) : 0, 8188
Remote Config [baseline] (591.241 µs) : 0, 591
Remote Config [candidate] (579.031 µs) : 0, 579
Telemetry [baseline] (9.174 ms) : 0, 9174
Telemetry [candidate] (8.276 ms) : 0, 8276
IAST [baseline] (29.088 ms) : 0, 29088
IAST [candidate] (26.688 ms) : 0, 26688
section profiling
crashtracking [baseline] (1.398 ms) : 0, 1398
crashtracking [candidate] (1.399 ms) : 0, 1399
BytebuddyAgent [baseline] (759.728 ms) : 0, 759728
BytebuddyAgent [candidate] (760.209 ms) : 0, 760209
GlobalTracer [baseline] (221.853 ms) : 0, 221853
GlobalTracer [candidate] (221.416 ms) : 0, 221416
AppSec [baseline] (29.925 ms) : 0, 29925
AppSec [candidate] (29.8 ms) : 0, 29800
Debugger [baseline] (6.968 ms) : 0, 6968
Debugger [candidate] (6.273 ms) : 0, 6273
Remote Config [baseline] (660.751 µs) : 0, 661
Remote Config [candidate] (685.173 µs) : 0, 685
Telemetry [baseline] (15.034 ms) : 0, 15034
Telemetry [candidate] (15.475 ms) : 0, 15475
ProfilingAgent [baseline] (107.133 ms) : 0, 107133
ProfilingAgent [candidate] (107.993 ms) : 0, 107993
Profiling [baseline] (107.759 ms) : 0, 107759
Profiling [candidate] (108.629 ms) : 0, 108629
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~013f3af04d, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section baseline
no_agent (4.536 ms) : 4485, 4588
. : milestone, 4536,
iast (9.442 ms) : 9289, 9595
. : milestone, 9442,
iast_FULL (13.63 ms) : 13360, 13901
. : milestone, 13630,
iast_GLOBAL (10.446 ms) : 10264, 10628
. : milestone, 10446,
profiling (9.014 ms) : 8873, 9155
. : milestone, 9014,
tracing (7.629 ms) : 7519, 7738
. : milestone, 7629,
section candidate
no_agent (4.395 ms) : 4343, 4448
. : milestone, 4395,
iast (9.641 ms) : 9478, 9803
. : milestone, 9641,
iast_FULL (14.148 ms) : 13867, 14430
. : milestone, 14148,
iast_GLOBAL (9.94 ms) : 9769, 10110
. : milestone, 9940,
profiling (8.747 ms) : 8613, 8881
. : milestone, 8747,
tracing (7.661 ms) : 7550, 7772
. : milestone, 7661,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~013f3af04d, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section baseline
no_agent (36.984 ms) : 36683, 37284
. : milestone, 36984,
appsec (46.912 ms) : 46494, 47330
. : milestone, 46912,
code_origins (43.883 ms) : 43505, 44260
. : milestone, 43883,
iast (42.786 ms) : 42416, 43155
. : milestone, 42786,
profiling (47.935 ms) : 47488, 48382
. : milestone, 47935,
tracing (44.643 ms) : 44273, 45012
. : milestone, 44643,
section candidate
no_agent (36.834 ms) : 36535, 37133
. : milestone, 36834,
appsec (47.196 ms) : 46770, 47622
. : milestone, 47196,
code_origins (44.397 ms) : 44021, 44774
. : milestone, 44397,
iast (45.899 ms) : 45500, 46297
. : milestone, 45899,
profiling (47.205 ms) : 46765, 47644
. : milestone, 47205,
tracing (43.304 ms) : 42932, 43676
. : milestone, 43304,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~013f3af04d, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.677 ms) : 3459, 3895
. : milestone, 3677,
iast (2.216 ms) : 2153, 2280
. : milestone, 2216,
iast_GLOBAL (2.254 ms) : 2191, 2317
. : milestone, 2254,
profiling (2.068 ms) : 2017, 2119
. : milestone, 2068,
tracing (2.034 ms) : 1984, 2083
. : milestone, 2034,
section candidate
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.699 ms) : 3480, 3918
. : milestone, 3699,
iast (2.22 ms) : 2156, 2283
. : milestone, 2220,
iast_GLOBAL (2.259 ms) : 2195, 2323
. : milestone, 2259,
profiling (2.483 ms) : 2324, 2641
. : milestone, 2483,
tracing (2.025 ms) : 1976, 2074
. : milestone, 2025,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~013f3af04d, baseline=1.53.0-SNAPSHOT~fa0bdff580
dateFormat X
axisFormat %s
section baseline
no_agent (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
appsec (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
iast (18.189 s) : 18189000, 18189000
. : milestone, 18189000,
iast_GLOBAL (17.997 s) : 17997000, 17997000
. : milestone, 17997000,
profiling (15.531 s) : 15531000, 15531000
. : milestone, 15531000,
tracing (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
section candidate
no_agent (15.27 s) : 15270000, 15270000
. : milestone, 15270000,
appsec (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
iast (18.371 s) : 18371000, 18371000
. : milestone, 18371000,
iast_GLOBAL (17.952 s) : 17952000, 17952000
. : milestone, 17952000,
profiling (15.408 s) : 15408000, 15408000
. : milestone, 15408000,
tracing (15.099 s) : 15099000, 15099000
. : milestone, 15099000,
|
Code coverage: total 57.31%, base diff -0.01%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 013f3af | Docs | Was this helpful? Give us feedback! |
What Does This Do
Update the
add-release-to-cloudfoundry
,update-docker-build-image
,update-gradle-dependencies
, andupdate-jmxfetch-submodule
workflows to usedd-octo-sts
to sign commits, push PRs, etc.Motivation
Use Datadog
dd-octo-sts
token verification instead of Github tokens.Additional Notes
Signing commits in public repositories when using dd-octo-sts was a great help with this.
The
add-release-to-cloudfoundry
workflow can only be tested during a release. If it fails, it should not impact production and can be easily recovered by doing the repository update manually.Still need to test the others...
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-701