Skip to content

Pool unionmap for log injection #9555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Pool unionmap for log injection #9555

wants to merge 4 commits into from
+18 −4

Conversation

amarziali
Copy link
Contributor

@amarziali amarziali commented Sep 17, 2025 •
edited
Loading

What Does This Do

UnionMaps are used to provide a multimap view backed on original logger's mdc.

The mdc is used to be bound to a thread locality. In recent heap dumps I noticed that we largely allocate instances of this class. Specifically wrt MDC, those objects can be pooled

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-official Datadog Official
Copy link

datadog-official bot commented Sep 17, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 63.36% (+3.67%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7c5a065 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/test-union
git_commit_date 1759910850 1759917053
git_commit_sha 60a3b9d 7c5a065
release_version 1.55.0-SNAPSHOT~60a3b9d880 1.54.0-SNAPSHOT~7c5a0652b5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759918735 1759918735
ci_job_id 1168972835 1168972835
ci_pipeline_id 78699739 78699739
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-lf5rmm5c 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-lf5rmm5c 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 2 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~7c5a0652b5, baseline=1.55.0-SNAPSHOT~60a3b9d880

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017603
Total [baseline] (8.673 s) : 0, 8673378
Agent [candidate] (1.019 s) : 0, 1019066
Total [candidate] (8.676 s) : 0, 8676113
section iast
Agent [baseline] (1.158 s) : 0, 1158065
Total [baseline] (9.365 s) : 0, 9364963
Agent [candidate] (1.149 s) : 0, 1149036
Total [candidate] (9.273 s) : 0, 9272716
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent iast 1.158 s 140.461 ms (13.8%)
Total tracing 8.673 s -
Total iast 9.365 s 691.585 ms (8.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent iast 1.149 s 129.971 ms (12.8%)
Total tracing 8.676 s -
Total iast 9.273 s 596.602 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~7c5a0652b5, baseline=1.55.0-SNAPSHOT~60a3b9d880

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (692.427 ms) : 0, 692427
BytebuddyAgent [candidate] (693.808 ms) : 0, 693808
GlobalTracer [baseline] (241.628 ms) : 0, 241628
GlobalTracer [candidate] (241.852 ms) : 0, 241852
AppSec [baseline] (32.84 ms) : 0, 32840
AppSec [candidate] (32.726 ms) : 0, 32726
Debugger [baseline] (6.42 ms) : 0, 6420
Debugger [candidate] (6.389 ms) : 0, 6389
Remote Config [baseline] (702.538 µs) : 0, 703
Remote Config [candidate] (701.454 µs) : 0, 701
Telemetry [baseline] (9.253 ms) : 0, 9253
Telemetry [candidate] (9.234 ms) : 0, 9234
Flare Poller [baseline] (11.701 ms) : 0, 11701
Flare Poller [candidate] (11.751 ms) : 0, 11751
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (819.544 ms) : 0, 819544
BytebuddyAgent [candidate] (813.861 ms) : 0, 813861
GlobalTracer [baseline] (232.631 ms) : 0, 232631
GlobalTracer [candidate] (231.243 ms) : 0, 231243
IAST [baseline] (26.89 ms) : 0, 26890
IAST [candidate] (26.211 ms) : 0, 26211
AppSec [baseline] (36.276 ms) : 0, 36276
AppSec [candidate] (35.48 ms) : 0, 35480
Debugger [baseline] (6.206 ms) : 0, 6206
Debugger [candidate] (6.141 ms) : 0, 6141
Remote Config [baseline] (626.64 µs) : 0, 627
Remote Config [candidate] (601.276 µs) : 0, 601
Telemetry [baseline] (8.805 ms) : 0, 8805
Telemetry [candidate] (8.579 ms) : 0, 8579
Flare Poller [baseline] (4.249 ms) : 0, 4249
Flare Poller [candidate] (4.208 ms) : 0, 4208
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~7c5a0652b5, baseline=1.55.0-SNAPSHOT~60a3b9d880

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1015627
Total [baseline] (10.673 s) : 0, 10673081
Agent [candidate] (1.014 s) : 0, 1013764
Total [candidate] (10.724 s) : 0, 10723503
section appsec
Agent [baseline] (1.195 s) : 0, 1194869
Total [baseline] (11.092 s) : 0, 11092470
Agent [candidate] (1.19 s) : 0, 1190412
Total [candidate] (11.046 s) : 0, 11045872
section iast
Agent [baseline] (1.159 s) : 0, 1158890
Total [baseline] (11.032 s) : 0, 11032407
Agent [candidate] (1.153 s) : 0, 1152566
Total [candidate] (10.94 s) : 0, 10939981
section profiling
Agent [baseline] (1.163 s) : 0, 1162649
Total [baseline] (11.029 s) : 0, 11028882
Agent [candidate] (1.166 s) : 0, 1166212
Total [candidate] (11.084 s) : 0, 11083539
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.016 s -
Agent appsec 1.195 s 179.242 ms (17.6%)
Agent iast 1.159 s 143.263 ms (14.1%)
Agent profiling 1.163 s 147.022 ms (14.5%)
Total tracing 10.673 s -
Total appsec 11.092 s 419.388 ms (3.9%)
Total iast 11.032 s 359.325 ms (3.4%)
Total profiling 11.029 s 355.8 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent appsec 1.19 s 176.648 ms (17.4%)
Agent iast 1.153 s 138.802 ms (13.7%)
Agent profiling 1.166 s 152.448 ms (15.0%)
Total tracing 10.724 s -
Total appsec 11.046 s 322.369 ms (3.0%)
Total iast 10.94 s 216.478 ms (2.0%)
Total profiling 11.084 s 360.036 ms (3.4%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~7c5a0652b5, baseline=1.55.0-SNAPSHOT~60a3b9d880

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (692.553 ms) : 0, 692553
BytebuddyAgent [candidate] (690.997 ms) : 0, 690997
GlobalTracer [baseline] (241.621 ms) : 0, 241621
GlobalTracer [candidate] (241.116 ms) : 0, 241116
AppSec [baseline] (32.859 ms) : 0, 32859
AppSec [candidate] (32.594 ms) : 0, 32594
Debugger [baseline] (6.41 ms) : 0, 6410
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (765.272 µs) : 0, 765
Remote Config [candidate] (692.014 µs) : 0, 692
Telemetry [baseline] (9.245 ms) : 0, 9245
Telemetry [candidate] (9.118 ms) : 0, 9118
Flare Poller [baseline] (9.505 ms) : 0, 9505
Flare Poller [candidate] (10.226 ms) : 0, 10226
section appsec
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (717.551 ms) : 0, 717551
BytebuddyAgent [candidate] (715.333 ms) : 0, 715333
GlobalTracer [baseline] (234.363 ms) : 0, 234363
GlobalTracer [candidate] (234.042 ms) : 0, 234042
IAST [baseline] (24.737 ms) : 0, 24737
IAST [candidate] (24.566 ms) : 0, 24566
AppSec [baseline] (176.45 ms) : 0, 176450
AppSec [candidate] (174.991 ms) : 0, 174991
Debugger [baseline] (6.098 ms) : 0, 6098
Debugger [candidate] (6.066 ms) : 0, 6066
Remote Config [baseline] (658.765 µs) : 0, 659
Remote Config [candidate] (643.689 µs) : 0, 644
Telemetry [baseline] (8.491 ms) : 0, 8491
Telemetry [candidate] (8.381 ms) : 0, 8381
Flare Poller [baseline] (3.95 ms) : 0, 3950
Flare Poller [candidate] (3.926 ms) : 0, 3926
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (820.775 ms) : 0, 820775
BytebuddyAgent [candidate] (816.261 ms) : 0, 816261
GlobalTracer [baseline] (232.756 ms) : 0, 232756
GlobalTracer [candidate] (231.901 ms) : 0, 231901
IAST [baseline] (26.665 ms) : 0, 26665
IAST [candidate] (26.503 ms) : 0, 26503
AppSec [baseline] (35.893 ms) : 0, 35893
AppSec [candidate] (35.734 ms) : 0, 35734
Debugger [baseline] (6.195 ms) : 0, 6195
Debugger [candidate] (6.108 ms) : 0, 6108
Remote Config [baseline] (627.963 µs) : 0, 628
Remote Config [candidate] (601.279 µs) : 0, 601
Telemetry [baseline] (8.801 ms) : 0, 8801
Telemetry [candidate] (8.476 ms) : 0, 8476
Flare Poller [baseline] (4.239 ms) : 0, 4239
Flare Poller [candidate] (4.198 ms) : 0, 4198
section profiling
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (721.275 ms) : 0, 721275
BytebuddyAgent [candidate] (723.274 ms) : 0, 723274
GlobalTracer [baseline] (217.291 ms) : 0, 217291
GlobalTracer [candidate] (218.324 ms) : 0, 218324
AppSec [baseline] (33.003 ms) : 0, 33003
AppSec [candidate] (33.363 ms) : 0, 33363
Debugger [baseline] (6.445 ms) : 0, 6445
Debugger [candidate] (6.506 ms) : 0, 6506
Remote Config [baseline] (701.98 µs) : 0, 702
Remote Config [candidate] (702.159 µs) : 0, 702
Telemetry [baseline] (16.804 ms) : 0, 16804
Telemetry [candidate] (16.646 ms) : 0, 16646
Flare Poller [baseline] (4.23 ms) : 0, 4230
Flare Poller [candidate] (4.264 ms) : 0, 4264
ProfilingAgent [baseline] (107.997 ms) : 0, 107997
ProfilingAgent [candidate] (108.043 ms) : 0, 108043
Profiling [baseline] (109.527 ms) : 0, 109527
Profiling [candidate] (109.584 ms) : 0, 109584
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/test-union
git_commit_date 1759910850 1759917053
git_commit_sha 60a3b9d 7c5a065
release_version 1.55.0-SNAPSHOT~60a3b9d880 1.54.0-SNAPSHOT~7c5a0652b5
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759918403 1759918403
ci_job_id 1168972836 1168972836
ci_pipeline_id 78699739 78699739
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-riw1wt0g 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-riw1wt0g 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 4 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load worse
[+399.531µs; +801.199µs] or [+3.870%; +7.761%]		 unstable
[-77.240op/s; +27.928op/s] or [-17.157%; +6.204%]		 10.923ms 425.531op/s 10.323ms 450.188op/s
scenario:load:insecure-bank:profiling:high_load better
[-637.327µs; -326.381µs] or [-6.923%; -3.545%]		 unstable
[-40.242op/s; +94.617op/s] or [-7.979%; +18.759%]		 8.724ms 531.562op/s 9.206ms 504.375op/s
scenario:load:petclinic:tracing:high_load better
[-3.367ms; -2.558ms] or [-7.467%; -5.673%]		 unstable
[-0.364op/s; +14.939op/s] or [-0.351%; +14.401%]		 42.128ms 111.025op/s 45.090ms 103.737op/s
scenario:load:petclinic:no_agent:high_load worse
[+1.974ms; +2.619ms] or [+5.416%; +7.188%]		 unstable
[-16.305op/s; +1.155op/s] or [-12.711%; +0.901%]		 38.738ms 120.700op/s 36.441ms 128.275op/s
scenario:load:petclinic:profiling:high_load worse
[+1.581ms; +2.615ms] or [+3.288%; +5.435%]		 unstable
[-11.322op/s; +3.322op/s] or [-11.640%; +3.415%]		 50.201ms 93.275op/s 48.103ms 97.275op/s
scenario:load:petclinic:appsec:high_load worse
[+1.067ms; +1.971ms] or [+2.283%; +4.217%]		 unstable
[-10.374op/s; +4.124op/s] or [-10.361%; +4.119%]		 48.273ms 97.000op/s 46.753ms 100.125op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~7c5a0652b5, baseline=1.55.0-SNAPSHOT~60a3b9d880
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.363 ms) : 4308, 4418
.   : milestone, 4363,
iast (9.633 ms) : 9477, 9789
.   : milestone, 9633,
iast_FULL (14.114 ms) : 13832, 14397
.   : milestone, 14114,
iast_GLOBAL (10.323 ms) : 10143, 10503
.   : milestone, 10323,
profiling (9.206 ms) : 9058, 9354
.   : milestone, 9206,
tracing (8.069 ms) : 7937, 8200
.   : milestone, 8069,
section candidate
no_agent (4.291 ms) : 4237, 4345
.   : milestone, 4291,
iast (9.59 ms) : 9427, 9753
.   : milestone, 9590,
iast_FULL (14.072 ms) : 13784, 14360
.   : milestone, 14072,
iast_GLOBAL (10.923 ms) : 10730, 11116
.   : milestone, 10923,
profiling (8.724 ms) : 8584, 8865
.   : milestone, 8724,
tracing (7.83 ms) : 7717, 7944
.   : milestone, 7830,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.363 ms [4.308 ms, 4.418 ms] -
iast 9.633 ms [9.477 ms, 9.789 ms] 5.27 ms (120.8%)
iast_FULL 14.114 ms [13.832 ms, 14.397 ms] 9.751 ms (223.5%)
iast_GLOBAL 10.323 ms [10.143 ms, 10.503 ms] 5.96 ms (136.6%)
profiling 9.206 ms [9.058 ms, 9.354 ms] 4.843 ms (111.0%)
tracing 8.069 ms [7.937 ms, 8.2 ms] 3.705 ms (84.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.291 ms [4.237 ms, 4.345 ms] -
iast 9.59 ms [9.427 ms, 9.753 ms] 5.299 ms (123.5%)
iast_FULL 14.072 ms [13.784 ms, 14.36 ms] 9.781 ms (227.9%)
iast_GLOBAL 10.923 ms [10.73 ms, 11.116 ms] 6.632 ms (154.6%)
profiling 8.724 ms [8.584 ms, 8.865 ms] 4.433 ms (103.3%)
tracing 7.83 ms [7.717 ms, 7.944 ms] 3.539 ms (82.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~7c5a0652b5, baseline=1.55.0-SNAPSHOT~60a3b9d880
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.441 ms) : 36151, 36731
.   : milestone, 36441,
appsec (46.753 ms) : 46337, 47170
.   : milestone, 46753,
code_origins (45.12 ms) : 44717, 45523
.   : milestone, 45120,
iast (44.972 ms) : 44594, 45349
.   : milestone, 44972,
profiling (48.103 ms) : 47632, 48574
.   : milestone, 48103,
tracing (45.09 ms) : 44699, 45482
.   : milestone, 45090,
section candidate
no_agent (38.738 ms) : 38428, 39047
.   : milestone, 38738,
appsec (48.273 ms) : 47849, 48696
.   : milestone, 48273,
code_origins (44.093 ms) : 43709, 44476
.   : milestone, 44093,
iast (43.698 ms) : 43324, 44072
.   : milestone, 43698,
profiling (50.201 ms) : 49712, 50690
.   : milestone, 50201,
tracing (42.128 ms) : 41768, 42488
.   : milestone, 42128,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.441 ms [36.151 ms, 36.731 ms] -
appsec 46.753 ms [46.337 ms, 47.17 ms] 10.312 ms (28.3%)
code_origins 45.12 ms [44.717 ms, 45.523 ms] 8.679 ms (23.8%)
iast 44.972 ms [44.594 ms, 45.349 ms] 8.531 ms (23.4%)
profiling 48.103 ms [47.632 ms, 48.574 ms] 11.662 ms (32.0%)
tracing 45.09 ms [44.699 ms, 45.482 ms] 8.649 ms (23.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 38.738 ms [38.428 ms, 39.047 ms] -
appsec 48.273 ms [47.849 ms, 48.696 ms] 9.535 ms (24.6%)
code_origins 44.093 ms [43.709 ms, 44.476 ms] 5.355 ms (13.8%)
iast 43.698 ms [43.324 ms, 44.072 ms] 4.96 ms (12.8%)
profiling 50.201 ms [49.712 ms, 50.69 ms] 11.463 ms (29.6%)
tracing 42.128 ms [41.768 ms, 42.488 ms] 3.39 ms (8.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/test-union
git_commit_date 1759910850 1759917053
git_commit_sha 60a3b9d 7c5a065
release_version 1.55.0-SNAPSHOT~60a3b9d880 1.54.0-SNAPSHOT~7c5a0652b5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1759918983 1759918983
ci_job_id 1168972837 1168972837
ci_pipeline_id 78699739 78699739
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-s6p2erhd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-s6p2erhd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~7c5a0652b5, baseline=1.55.0-SNAPSHOT~60a3b9d880
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.937 s) : 14937000, 14937000
.   : milestone, 14937000,
appsec (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
iast (18.595 s) : 18595000, 18595000
.   : milestone, 18595000,
iast_GLOBAL (18.066 s) : 18066000, 18066000
.   : milestone, 18066000,
profiling (14.982 s) : 14982000, 14982000
.   : milestone, 14982000,
tracing (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
section candidate
no_agent (14.916 s) : 14916000, 14916000
.   : milestone, 14916000,
appsec (15.263 s) : 15263000, 15263000
.   : milestone, 15263000,
iast (18.491 s) : 18491000, 18491000
.   : milestone, 18491000,
iast_GLOBAL (18.184 s) : 18184000, 18184000
.   : milestone, 18184000,
profiling (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
tracing (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.937 s [14.937 s, 14.937 s] -
appsec 15.019 s [15.019 s, 15.019 s] 82.0 ms (0.5%)
iast 18.595 s [18.595 s, 18.595 s] 3.658 s (24.5%)
iast_GLOBAL 18.066 s [18.066 s, 18.066 s] 3.129 s (20.9%)
profiling 14.982 s [14.982 s, 14.982 s] 45.0 ms (0.3%)
tracing 15.071 s [15.071 s, 15.071 s] 134.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.916 s [14.916 s, 14.916 s] -
appsec 15.263 s [15.263 s, 15.263 s] 347.0 ms (2.3%)
iast 18.491 s [18.491 s, 18.491 s] 3.575 s (24.0%)
iast_GLOBAL 18.184 s [18.184 s, 18.184 s] 3.268 s (21.9%)
profiling 15.03 s [15.03 s, 15.03 s] 114.0 ms (0.8%)
tracing 15.149 s [15.149 s, 15.149 s] 233.0 ms (1.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~7c5a0652b5, baseline=1.55.0-SNAPSHOT~60a3b9d880
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
.   : milestone, 1489,
appsec (3.742 ms) : 3523, 3960
.   : milestone, 3742,
iast (2.226 ms) : 2162, 2290
.   : milestone, 2226,
iast_GLOBAL (2.262 ms) : 2198, 2326
.   : milestone, 2262,
profiling (2.507 ms) : 2340, 2675
.   : milestone, 2507,
tracing (2.038 ms) : 1988, 2087
.   : milestone, 2038,
section candidate
no_agent (1.474 ms) : 1462, 1486
.   : milestone, 1474,
appsec (3.695 ms) : 3481, 3908
.   : milestone, 3695,
iast (2.207 ms) : 2144, 2271
.   : milestone, 2207,
iast_GLOBAL (2.271 ms) : 2207, 2335
.   : milestone, 2271,
profiling (2.086 ms) : 2033, 2139
.   : milestone, 2086,
tracing (2.039 ms) : 1990, 2089
.   : milestone, 2039,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.489 ms [1.477 ms, 1.501 ms] -
appsec 3.742 ms [3.523 ms, 3.96 ms] 2.253 ms (151.3%)
iast 2.226 ms [2.162 ms, 2.29 ms] 737.076 µs (49.5%)
iast_GLOBAL 2.262 ms [2.198 ms, 2.326 ms] 773.176 µs (51.9%)
profiling 2.507 ms [2.34 ms, 2.675 ms] 1.018 ms (68.4%)
tracing 2.038 ms [1.988 ms, 2.087 ms] 548.825 µs (36.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.486 ms] -
appsec 3.695 ms [3.481 ms, 3.908 ms] 2.221 ms (150.7%)
iast 2.207 ms [2.144 ms, 2.271 ms] 733.368 µs (49.8%)
iast_GLOBAL 2.271 ms [2.207 ms, 2.335 ms] 796.968 µs (54.1%)
profiling 2.086 ms [2.033 ms, 2.139 ms] 612.157 µs (41.5%)
tracing 2.039 ms [1.99 ms, 2.089 ms] 565.438 µs (38.4%)

@amarziali amarziali force-pushed the andrea.marziali/test-union branch from 61f2c07 to e60ce1a Compare September 17, 2025 16:04
@amarziali amarziali marked this pull request as ready for review September 18, 2025 08:36
@amarziali amarziali requested review from a team as code owners September 18, 2025 08:36
@amarziali amarziali requested a review from smola September 18, 2025 08:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali added tag: performance Performance related changes comp: logging Tracer internal logging type: enhancement Enhancements and improvements labels Sep 18, 2025
@amarziali amarziali changed the title test reusing unionmaps Pool unionmap for log injection Sep 18, 2025
@amarziali amarziali requested review from dougqh and mcculls September 18, 2025 16:30
dougqh
dougqh reviewed Sep 19, 2025
View reviewed changes
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/log/UnionMap.java Outdated
}

@SuppressWarnings({"unchecked"})
public static <K, V> UnionMap<K, V> create(Map<K, V> primaryMap, Map<K, V> secondaryMap) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer some other name than create, but I'm not sure what that would be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to obtain. It looks not so bad for this kind of action

@amarziali amarziali force-pushed the andrea.marziali/test-union branch from 5a47b6f to 4fb3661 Compare September 29, 2025 12:15
@amarziali amarziali requested a review from dougqh October 1, 2025 13:28
bric3
bric3 reviewed Oct 8, 2025
View reviewed changes
dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/log/UnionMap.java
private Map<K, V> secondaryMap;
private transient Set<Map.Entry<K, V>> entrySet;
private transient volatile boolean deduped;
private static final ThreadLocal<UnionMap<?, ?>> TL = ThreadLocal.withInitial(UnionMap::new);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is there a common topic with thread local span builders and virtual thread, i.e. should this avoid creating a threadlocal as well with VT. If so shall we extract a "common piece" to handle that.
cc @dougqh.

@amarziali amarziali marked this pull request as draft October 9, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bric3 bric3 bric3 left review comments

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

@mcculls mcculls Awaiting requested review from mcculls

@dougqh dougqh Awaiting requested review from dougqh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
comp: logging Tracer internal logging tag: performance Performance related changes type: enhancement Enhancements and improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amarziali @dougqh @bric3