-
Notifications
You must be signed in to change notification settings - Fork 312
Rewrite test-suites in kotlin #9587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎯 Code Coverage 🔗 Commit SHA: 4081713 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~4081713026, baseline=1.54.0-SNAPSHOT~b91074c79a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021678
Total [baseline] (8.683 s) : 0, 8682764
Agent [candidate] (1.019 s) : 0, 1018529
Total [candidate] (8.649 s) : 0, 8649166
section iast
Agent [baseline] (1.156 s) : 0, 1156379
Total [baseline] (9.317 s) : 0, 9317443
Agent [candidate] (1.161 s) : 0, 1160707
Total [candidate] (9.404 s) : 0, 9403986
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~4081713026, baseline=1.54.0-SNAPSHOT~b91074c79a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (689.748 ms) : 0, 689748
BytebuddyAgent [candidate] (687.36 ms) : 0, 687360
GlobalTracer [baseline] (257.929 ms) : 0, 257929
GlobalTracer [candidate] (258.299 ms) : 0, 258299
AppSec [baseline] (31.707 ms) : 0, 31707
AppSec [candidate] (31.633 ms) : 0, 31633
Debugger [baseline] (6.34 ms) : 0, 6340
Debugger [candidate] (6.359 ms) : 0, 6359
Remote Config [baseline] (685.842 µs) : 0, 686
Remote Config [candidate] (678.825 µs) : 0, 679
Telemetry [baseline] (12.829 ms) : 0, 12829
Telemetry [candidate] (11.772 ms) : 0, 11772
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (811.592 ms) : 0, 811592
BytebuddyAgent [candidate] (813.355 ms) : 0, 813355
GlobalTracer [baseline] (248.281 ms) : 0, 248281
GlobalTracer [candidate] (250.604 ms) : 0, 250604
AppSec [baseline] (29.091 ms) : 0, 29091
AppSec [candidate] (26.619 ms) : 0, 26619
Debugger [baseline] (6.136 ms) : 0, 6136
Debugger [candidate] (6.137 ms) : 0, 6137
Remote Config [baseline] (598.359 µs) : 0, 598
Remote Config [candidate] (599.73 µs) : 0, 600
Telemetry [baseline] (8.203 ms) : 0, 8203
Telemetry [candidate] (8.096 ms) : 0, 8096
IAST [baseline] (30.079 ms) : 0, 30079
IAST [candidate] (32.769 ms) : 0, 32769
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~4081713026, baseline=1.54.0-SNAPSHOT~b91074c79a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027548
Total [baseline] (10.723 s) : 0, 10723242
Agent [candidate] (1.026 s) : 0, 1025724
Total [candidate] (10.691 s) : 0, 10691169
section appsec
Agent [baseline] (1.203 s) : 0, 1203144
Total [baseline] (10.96 s) : 0, 10960310
Agent [candidate] (1.196 s) : 0, 1195531
Total [candidate] (10.976 s) : 0, 10976263
section iast
Agent [baseline] (1.154 s) : 0, 1153810
Total [baseline] (11.033 s) : 0, 11033013
Agent [candidate] (1.161 s) : 0, 1160892
Total [candidate] (11.116 s) : 0, 11115566
section profiling
Agent [baseline] (1.171 s) : 0, 1171124
Total [baseline] (11.031 s) : 0, 11030574
Agent [candidate] (1.165 s) : 0, 1164966
Total [candidate] (11.063 s) : 0, 11062806
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~4081713026, baseline=1.54.0-SNAPSHOT~b91074c79a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (692.353 ms) : 0, 692353
BytebuddyAgent [candidate] (691.537 ms) : 0, 691537
GlobalTracer [baseline] (259.258 ms) : 0, 259258
GlobalTracer [candidate] (259.895 ms) : 0, 259895
AppSec [baseline] (32.002 ms) : 0, 32002
AppSec [candidate] (32.069 ms) : 0, 32069
Debugger [baseline] (6.41 ms) : 0, 6410
Debugger [candidate] (6.381 ms) : 0, 6381
Remote Config [baseline] (685.225 µs) : 0, 685
Remote Config [candidate] (679.441 µs) : 0, 679
Telemetry [baseline] (14.229 ms) : 0, 14229
Telemetry [candidate] (12.563 ms) : 0, 12563
section appsec
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (715.727 ms) : 0, 715727
BytebuddyAgent [candidate] (710.15 ms) : 0, 710150
GlobalTracer [baseline] (251.164 ms) : 0, 251164
GlobalTracer [candidate] (250.973 ms) : 0, 250973
AppSec [baseline] (172.485 ms) : 0, 172485
AppSec [candidate] (170.236 ms) : 0, 170236
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (5.989 ms) : 0, 5989
Remote Config [baseline] (620.981 µs) : 0, 621
Remote Config [candidate] (602.972 µs) : 0, 603
Telemetry [baseline] (9.253 ms) : 0, 9253
Telemetry [candidate] (9.987 ms) : 0, 9987
IAST [baseline] (25.17 ms) : 0, 25170
IAST [candidate] (25.09 ms) : 0, 25090
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (809.015 ms) : 0, 809015
BytebuddyAgent [candidate] (813.584 ms) : 0, 813584
GlobalTracer [baseline] (248.194 ms) : 0, 248194
GlobalTracer [candidate] (250.809 ms) : 0, 250809
AppSec [baseline] (29.111 ms) : 0, 29111
AppSec [candidate] (27.265 ms) : 0, 27265
Debugger [baseline] (6.152 ms) : 0, 6152
Debugger [candidate] (6.178 ms) : 0, 6178
Remote Config [baseline] (602.294 µs) : 0, 602
Remote Config [candidate] (626.834 µs) : 0, 627
Telemetry [baseline] (8.277 ms) : 0, 8277
Telemetry [candidate] (8.142 ms) : 0, 8142
IAST [baseline] (30.04 ms) : 0, 30040
IAST [candidate] (31.798 ms) : 0, 31798
section profiling
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (724.79 ms) : 0, 724790
BytebuddyAgent [candidate] (720.031 ms) : 0, 720031
GlobalTracer [baseline] (236.433 ms) : 0, 236433
GlobalTracer [candidate] (236.285 ms) : 0, 236285
AppSec [baseline] (31.386 ms) : 0, 31386
AppSec [candidate] (30.99 ms) : 0, 30990
Debugger [baseline] (6.518 ms) : 0, 6518
Debugger [candidate] (6.479 ms) : 0, 6479
Remote Config [baseline] (721.726 µs) : 0, 722
Remote Config [candidate] (696.656 µs) : 0, 697
Telemetry [baseline] (16.522 ms) : 0, 16522
Telemetry [candidate] (15.756 ms) : 0, 15756
ProfilingAgent [baseline] (101.8 ms) : 0, 101800
ProfilingAgent [candidate] (101.36 ms) : 0, 101360
Profiling [baseline] (102.391 ms) : 0, 102391
Profiling [candidate] (101.959 ms) : 0, 101959
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4081713026, baseline=1.54.0-SNAPSHOT~b91074c79a
dateFormat X
axisFormat %s
section baseline
no_agent (4.426 ms) : 4369, 4483
. : milestone, 4426,
iast (9.236 ms) : 9085, 9386
. : milestone, 9236,
iast_FULL (14.711 ms) : 14410, 15011
. : milestone, 14711,
iast_GLOBAL (10.537 ms) : 10346, 10728
. : milestone, 10537,
profiling (9.701 ms) : 9533, 9869
. : milestone, 9701,
tracing (7.503 ms) : 7401, 7605
. : milestone, 7503,
section candidate
no_agent (4.543 ms) : 4484, 4602
. : milestone, 4543,
iast (9.62 ms) : 9460, 9780
. : milestone, 9620,
iast_FULL (13.919 ms) : 13643, 14195
. : milestone, 13919,
iast_GLOBAL (10.572 ms) : 10386, 10757
. : milestone, 10572,
profiling (9.193 ms) : 9041, 9345
. : milestone, 9193,
tracing (7.945 ms) : 7825, 8065
. : milestone, 7945,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4081713026, baseline=1.54.0-SNAPSHOT~b91074c79a
dateFormat X
axisFormat %s
section baseline
no_agent (36.293 ms) : 36001, 36584
. : milestone, 36293,
appsec (47.981 ms) : 47548, 48415
. : milestone, 47981,
code_origins (42.925 ms) : 42550, 43299
. : milestone, 42925,
iast (43.834 ms) : 43465, 44204
. : milestone, 43834,
profiling (47.005 ms) : 46559, 47452
. : milestone, 47005,
tracing (43.218 ms) : 42854, 43582
. : milestone, 43218,
section candidate
no_agent (35.945 ms) : 35665, 36225
. : milestone, 35945,
appsec (47.631 ms) : 47196, 48065
. : milestone, 47631,
code_origins (44.942 ms) : 44557, 45327
. : milestone, 44942,
iast (45.528 ms) : 45124, 45933
. : milestone, 45528,
profiling (50.022 ms) : 49546, 50498
. : milestone, 50022,
tracing (43.865 ms) : 43493, 44237
. : milestone, 43865,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4081713026, baseline=1.54.0-SNAPSHOT~b91074c79a
dateFormat X
axisFormat %s
section baseline
no_agent (15.495 s) : 15495000, 15495000
. : milestone, 15495000,
appsec (15.071 s) : 15071000, 15071000
. : milestone, 15071000,
iast (18.588 s) : 18588000, 18588000
. : milestone, 18588000,
iast_GLOBAL (18.479 s) : 18479000, 18479000
. : milestone, 18479000,
profiling (15.859 s) : 15859000, 15859000
. : milestone, 15859000,
tracing (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
section candidate
no_agent (14.802 s) : 14802000, 14802000
. : milestone, 14802000,
appsec (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
iast (18.356 s) : 18356000, 18356000
. : milestone, 18356000,
iast_GLOBAL (18.314 s) : 18314000, 18314000
. : milestone, 18314000,
profiling (15.982 s) : 15982000, 15982000
. : milestone, 15982000,
tracing (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4081713026, baseline=1.54.0-SNAPSHOT~b91074c79a
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.706 ms) : 3487, 3924
. : milestone, 3706,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.236 ms) : 2173, 2299
. : milestone, 2236,
profiling (2.048 ms) : 1997, 2099
. : milestone, 2048,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.444 ms) : 2394, 2494
. : milestone, 2444,
iast (2.197 ms) : 2135, 2259
. : milestone, 2197,
iast_GLOBAL (2.236 ms) : 2173, 2299
. : milestone, 2236,
profiling (2.059 ms) : 2008, 2109
. : milestone, 2059,
tracing (2.023 ms) : 1974, 2072
. : milestone, 2023,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for that !
Thinking ahead... : I wonder if we could make this a convention plugin immediately 🤔.
And, apply the plugin like this in java_no_deps.gradle
:
apply plugin = 'datadog.test-suites'
That being said, build.gradle
(so using groovy DSL) are unlikely be able to use the real methods like addTestSuiteExtendingForDir
, unless some compatibility code is added. Unsure at this time how to work around that.
fun Project.addTestSuiteExtendingForDir(testSuiteName: String, parentSuiteName: String, dirName: String) { | ||
testing { | ||
suites { | ||
create(testSuiteName, JvmTestSuite::class) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer use register
instead
What Does This Do
This PR creates a new file
test-suites.gradle.kts
, written in Kotlin. However, this Kotlin file cannot be easily used yet because it needs to replace the originaltest-suites.gradle
file. BUT, this file is called from the broader Groovy https://github.com/DataDog/dd-trace-java/blob/master/gradle/java_no_deps.gradle#L15 file, where theapply from:
mechanism only works for other Groovy files. Thus, we would need to convert all of these transitively dependent build files to Kotlin first, which is a massive undertaking...Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]