-
Notifications
You must be signed in to change notification settings - Fork 312
Split jetty-server-9.0
project setup to multiple modules
#9683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎯 Code Coverage 🔗 Commit SHA: d21a1aa | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~d21a1aa2b2, baseline=1.55.0-SNAPSHOT~1772b5b0ee
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1025085
Total [baseline] (8.653 s) : 0, 8653378
Agent [candidate] (1.017 s) : 0, 1017263
Total [candidate] (8.625 s) : 0, 8624817
section iast
Agent [baseline] (1.16 s) : 0, 1159596
Total [baseline] (9.213 s) : 0, 9212510
Agent [candidate] (1.149 s) : 0, 1149128
Total [candidate] (9.292 s) : 0, 9292373
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~d21a1aa2b2, baseline=1.55.0-SNAPSHOT~1772b5b0ee
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (698.595 ms) : 0, 698595
BytebuddyAgent [candidate] (694.115 ms) : 0, 694115
GlobalTracer [baseline] (243.484 ms) : 0, 243484
GlobalTracer [candidate] (241.502 ms) : 0, 241502
AppSec [baseline] (33.533 ms) : 0, 33533
AppSec [candidate] (32.764 ms) : 0, 32764
Debugger [baseline] (6.514 ms) : 0, 6514
Debugger [candidate] (6.36 ms) : 0, 6360
Remote Config [baseline] (708.798 µs) : 0, 709
Remote Config [candidate] (683.526 µs) : 0, 684
Telemetry [baseline] (9.424 ms) : 0, 9424
Telemetry [candidate] (9.34 ms) : 0, 9340
Flare Poller [baseline] (10.196 ms) : 0, 10196
Flare Poller [candidate] (9.951 ms) : 0, 9951
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (821.709 ms) : 0, 821709
BytebuddyAgent [candidate] (813.284 ms) : 0, 813284
GlobalTracer [baseline] (232.948 ms) : 0, 232948
GlobalTracer [candidate] (230.972 ms) : 0, 230972
AppSec [baseline] (35.618 ms) : 0, 35618
AppSec [candidate] (35.723 ms) : 0, 35723
Debugger [baseline] (6.136 ms) : 0, 6136
Debugger [candidate] (6.152 ms) : 0, 6152
Remote Config [baseline] (615.691 µs) : 0, 616
Remote Config [candidate] (604.898 µs) : 0, 605
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (8.753 ms) : 0, 8753
Flare Poller [baseline] (4.195 ms) : 0, 4195
Flare Poller [candidate] (4.243 ms) : 0, 4243
IAST [baseline] (26.81 ms) : 0, 26810
IAST [candidate] (26.739 ms) : 0, 26739
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~d21a1aa2b2, baseline=1.55.0-SNAPSHOT~1772b5b0ee
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1023304
Total [baseline] (10.716 s) : 0, 10716190
Agent [candidate] (1.017 s) : 0, 1016715
Total [candidate] (10.762 s) : 0, 10761882
section appsec
Agent [baseline] (1.193 s) : 0, 1192896
Total [baseline] (10.934 s) : 0, 10933952
Agent [candidate] (1.194 s) : 0, 1193674
Total [candidate] (10.939 s) : 0, 10938685
section iast
Agent [baseline] (1.154 s) : 0, 1153860
Total [baseline] (11.047 s) : 0, 11047233
Agent [candidate] (1.159 s) : 0, 1158544
Total [candidate] (10.939 s) : 0, 10939342
section profiling
Agent [baseline] (1.16 s) : 0, 1160304
Total [baseline] (11.052 s) : 0, 11051789
Agent [candidate] (1.16 s) : 0, 1159745
Total [candidate] (10.977 s) : 0, 10977321
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~d21a1aa2b2, baseline=1.55.0-SNAPSHOT~1772b5b0ee
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (697.435 ms) : 0, 697435
BytebuddyAgent [candidate] (693.679 ms) : 0, 693679
GlobalTracer [baseline] (242.882 ms) : 0, 242882
GlobalTracer [candidate] (241.334 ms) : 0, 241334
AppSec [baseline] (33.07 ms) : 0, 33070
AppSec [candidate] (32.804 ms) : 0, 32804
Debugger [baseline] (6.463 ms) : 0, 6463
Debugger [candidate] (6.418 ms) : 0, 6418
Remote Config [baseline] (690.047 µs) : 0, 690
Remote Config [candidate] (687.734 µs) : 0, 688
Telemetry [baseline] (9.271 ms) : 0, 9271
Telemetry [candidate] (9.241 ms) : 0, 9241
Flare Poller [baseline] (10.847 ms) : 0, 10847
Flare Poller [candidate] (10.017 ms) : 0, 10017
section appsec
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (716.921 ms) : 0, 716921
BytebuddyAgent [candidate] (717.935 ms) : 0, 717935
GlobalTracer [baseline] (234.004 ms) : 0, 234004
GlobalTracer [candidate] (233.808 ms) : 0, 233808
AppSec [baseline] (175.324 ms) : 0, 175324
AppSec [candidate] (175.198 ms) : 0, 175198
Debugger [baseline] (6.117 ms) : 0, 6117
Debugger [candidate] (6.193 ms) : 0, 6193
Remote Config [baseline] (645.884 µs) : 0, 646
Remote Config [candidate] (646.886 µs) : 0, 647
Telemetry [baseline] (8.493 ms) : 0, 8493
Telemetry [candidate] (8.526 ms) : 0, 8526
Flare Poller [baseline] (4.032 ms) : 0, 4032
Flare Poller [candidate] (4.002 ms) : 0, 4002
IAST [baseline] (24.823 ms) : 0, 24823
IAST [candidate] (24.734 ms) : 0, 24734
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (817.023 ms) : 0, 817023
BytebuddyAgent [candidate] (821.019 ms) : 0, 821019
GlobalTracer [baseline] (232.368 ms) : 0, 232368
GlobalTracer [candidate] (232.641 ms) : 0, 232641
AppSec [baseline] (35.417 ms) : 0, 35417
AppSec [candidate] (33.704 ms) : 0, 33704
Debugger [baseline] (6.157 ms) : 0, 6157
Debugger [candidate] (6.323 ms) : 0, 6323
Remote Config [baseline] (613.688 µs) : 0, 614
Remote Config [candidate] (612.17 µs) : 0, 612
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.657 ms) : 0, 8657
Flare Poller [baseline] (4.286 ms) : 0, 4286
Flare Poller [candidate] (4.263 ms) : 0, 4263
IAST [baseline] (26.574 ms) : 0, 26574
IAST [candidate] (28.567 ms) : 0, 28567
section profiling
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (720.23 ms) : 0, 720230
BytebuddyAgent [candidate] (719.517 ms) : 0, 719517
GlobalTracer [baseline] (216.996 ms) : 0, 216996
GlobalTracer [candidate] (217.167 ms) : 0, 217167
AppSec [baseline] (33.105 ms) : 0, 33105
AppSec [candidate] (33.198 ms) : 0, 33198
Debugger [baseline] (6.441 ms) : 0, 6441
Debugger [candidate] (6.468 ms) : 0, 6468
Remote Config [baseline] (716.511 µs) : 0, 717
Remote Config [candidate] (695.037 µs) : 0, 695
Telemetry [baseline] (16.574 ms) : 0, 16574
Telemetry [candidate] (16.636 ms) : 0, 16636
Flare Poller [baseline] (4.191 ms) : 0, 4191
Flare Poller [candidate] (4.201 ms) : 0, 4201
ProfilingAgent [baseline] (107.617 ms) : 0, 107617
ProfilingAgent [candidate] (107.074 ms) : 0, 107074
Profiling [baseline] (108.756 ms) : 0, 108756
Profiling [candidate] (108.621 ms) : 0, 108621
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d21a1aa2b2, baseline=1.55.0-SNAPSHOT~1772b5b0ee
dateFormat X
axisFormat %s
section baseline
no_agent (38.195 ms) : 37884, 38507
. : milestone, 38195,
appsec (51.47 ms) : 51001, 51939
. : milestone, 51470,
code_origins (43.874 ms) : 43504, 44244
. : milestone, 43874,
iast (44.232 ms) : 43857, 44607
. : milestone, 44232,
profiling (48.46 ms) : 47994, 48926
. : milestone, 48460,
tracing (44.151 ms) : 43768, 44534
. : milestone, 44151,
section candidate
no_agent (37.599 ms) : 37306, 37892
. : milestone, 37599,
appsec (49.293 ms) : 48840, 49746
. : milestone, 49293,
code_origins (42.752 ms) : 42389, 43115
. : milestone, 42752,
iast (45.135 ms) : 44748, 45523
. : milestone, 45135,
profiling (47.558 ms) : 47124, 47992
. : milestone, 47558,
tracing (44.87 ms) : 44481, 45258
. : milestone, 44870,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d21a1aa2b2, baseline=1.55.0-SNAPSHOT~1772b5b0ee
dateFormat X
axisFormat %s
section baseline
no_agent (4.555 ms) : 4497, 4613
. : milestone, 4555,
iast (10.476 ms) : 10298, 10654
. : milestone, 10476,
iast_FULL (14.959 ms) : 14659, 15258
. : milestone, 14959,
iast_GLOBAL (11.141 ms) : 10941, 11341
. : milestone, 11141,
profiling (9.357 ms) : 9198, 9516
. : milestone, 9357,
tracing (7.6 ms) : 7480, 7719
. : milestone, 7600,
section candidate
no_agent (4.39 ms) : 4341, 4439
. : milestone, 4390,
iast (9.809 ms) : 9641, 9976
. : milestone, 9809,
iast_FULL (13.774 ms) : 13501, 14047
. : milestone, 13774,
iast_GLOBAL (10.538 ms) : 10346, 10730
. : milestone, 10538,
profiling (9.013 ms) : 8870, 9156
. : milestone, 9013,
tracing (7.929 ms) : 7816, 8042
. : milestone, 7929,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d21a1aa2b2, baseline=1.55.0-SNAPSHOT~1772b5b0ee
dateFormat X
axisFormat %s
section baseline
no_agent (14.883 s) : 14883000, 14883000
. : milestone, 14883000,
appsec (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
iast (18.825 s) : 18825000, 18825000
. : milestone, 18825000,
iast_GLOBAL (18.043 s) : 18043000, 18043000
. : milestone, 18043000,
profiling (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
tracing (15.142 s) : 15142000, 15142000
. : milestone, 15142000,
section candidate
no_agent (14.919 s) : 14919000, 14919000
. : milestone, 14919000,
appsec (14.973 s) : 14973000, 14973000
. : milestone, 14973000,
iast (18.576 s) : 18576000, 18576000
. : milestone, 18576000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
. : milestone, 18038000,
profiling (15.379 s) : 15379000, 15379000
. : milestone, 15379000,
tracing (15.148 s) : 15148000, 15148000
. : milestone, 15148000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d21a1aa2b2, baseline=1.55.0-SNAPSHOT~1772b5b0ee
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.643 ms) : 3430, 3856
. : milestone, 3643,
iast (2.21 ms) : 2146, 2273
. : milestone, 2210,
iast_GLOBAL (2.245 ms) : 2181, 2309
. : milestone, 2245,
profiling (2.471 ms) : 2312, 2630
. : milestone, 2471,
tracing (2.03 ms) : 1981, 2080
. : milestone, 2030,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.638 ms) : 3426, 3851
. : milestone, 3638,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.238 ms) : 2174, 2302
. : milestone, 2238,
profiling (2.072 ms) : 2019, 2125
. : milestone, 2072,
tracing (2.023 ms) : 1974, 2073
. : milestone, 2023,
|
206a126
to
c96dd02
Compare
jetty-server-9.0
project setup to multiple modules
c96dd02
to
f54d450
Compare
f54d450
to
1b67b9b
Compare
What Does This Do
Split jersey-server-9.0 specific version instrumentation spread in different
sourceSets
to dedicated instrumentation modules. In doing so , simplify the project setup.Motivation
jersey-server-9.0
instrumentation module had a complicated project setup, that had to deal with cyclic dependencies between classes and their instrumentation. This was difficult to maintain and this also prevented to proceed withAdditional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]