-
Notifications
You must be signed in to change notification settings - Fork 312
Add origin header to crashtracking telemetry #9685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
🎯 Code Coverage 🔗 Commit SHA: 9bec966 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~9bec9664b7, baseline=1.55.0-SNAPSHOT~1cd237641d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018659
Total [baseline] (10.722 s) : 0, 10722324
Agent [candidate] (1.023 s) : 0, 1022812
Total [candidate] (10.739 s) : 0, 10738657
section appsec
Agent [baseline] (1.193 s) : 0, 1192898
Total [baseline] (10.984 s) : 0, 10983943
Agent [candidate] (1.19 s) : 0, 1190287
Total [candidate] (11.043 s) : 0, 11043161
section iast
Agent [baseline] (1.15 s) : 0, 1149572
Total [baseline] (11.055 s) : 0, 11054599
Agent [candidate] (1.159 s) : 0, 1158763
Total [candidate] (11.082 s) : 0, 11081718
section profiling
Agent [baseline] (1.161 s) : 0, 1160679
Total [baseline] (11.017 s) : 0, 11017089
Agent [candidate] (1.169 s) : 0, 1168593
Total [candidate] (11.028 s) : 0, 11028058
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~9bec9664b7, baseline=1.55.0-SNAPSHOT~1cd237641d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (694.134 ms) : 0, 694134
BytebuddyAgent [candidate] (698.629 ms) : 0, 698629
GlobalTracer [baseline] (241.955 ms) : 0, 241955
GlobalTracer [candidate] (242.552 ms) : 0, 242552
AppSec [baseline] (32.846 ms) : 0, 32846
AppSec [candidate] (32.782 ms) : 0, 32782
Debugger [baseline] (6.374 ms) : 0, 6374
Debugger [candidate] (6.395 ms) : 0, 6395
Remote Config [baseline] (678.636 µs) : 0, 679
Remote Config [candidate] (691.202 µs) : 0, 691
Telemetry [baseline] (9.28 ms) : 0, 9280
Telemetry [candidate] (9.205 ms) : 0, 9205
Flare Poller [baseline] (10.885 ms) : 0, 10885
Flare Poller [candidate] (9.948 ms) : 0, 9948
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (717.282 ms) : 0, 717282
BytebuddyAgent [candidate] (715.645 ms) : 0, 715645
GlobalTracer [baseline] (234.088 ms) : 0, 234088
GlobalTracer [candidate] (234.009 ms) : 0, 234009
IAST [baseline] (24.822 ms) : 0, 24822
IAST [candidate] (24.7 ms) : 0, 24700
AppSec [baseline] (174.291 ms) : 0, 174291
AppSec [candidate] (174.416 ms) : 0, 174416
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.057 ms) : 0, 6057
Remote Config [baseline] (662.422 µs) : 0, 662
Remote Config [candidate] (633.097 µs) : 0, 633
Telemetry [baseline] (9.121 ms) : 0, 9121
Telemetry [candidate] (8.449 ms) : 0, 8449
Flare Poller [baseline] (3.978 ms) : 0, 3978
Flare Poller [candidate] (3.924 ms) : 0, 3924
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (814.378 ms) : 0, 814378
BytebuddyAgent [candidate] (820.673 ms) : 0, 820673
GlobalTracer [baseline] (231.419 ms) : 0, 231419
GlobalTracer [candidate] (233.544 ms) : 0, 233544
IAST [baseline] (26.495 ms) : 0, 26495
IAST [candidate] (26.857 ms) : 0, 26857
AppSec [baseline] (35.159 ms) : 0, 35159
AppSec [candidate] (35.34 ms) : 0, 35340
Debugger [baseline] (6.124 ms) : 0, 6124
Debugger [candidate] (6.122 ms) : 0, 6122
Remote Config [baseline] (602.206 µs) : 0, 602
Remote Config [candidate] (608.655 µs) : 0, 609
Telemetry [baseline] (8.553 ms) : 0, 8553
Telemetry [candidate] (8.604 ms) : 0, 8604
Flare Poller [baseline] (4.194 ms) : 0, 4194
Flare Poller [candidate] (4.23 ms) : 0, 4230
section profiling
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (720.836 ms) : 0, 720836
BytebuddyAgent [candidate] (726.499 ms) : 0, 726499
GlobalTracer [baseline] (217.102 ms) : 0, 217102
GlobalTracer [candidate] (218.155 ms) : 0, 218155
AppSec [baseline] (33.059 ms) : 0, 33059
AppSec [candidate] (33.331 ms) : 0, 33331
Debugger [baseline] (6.491 ms) : 0, 6491
Debugger [candidate] (7.328 ms) : 0, 7328
Remote Config [baseline] (699.102 µs) : 0, 699
Remote Config [candidate] (729.079 µs) : 0, 729
Telemetry [baseline] (16.479 ms) : 0, 16479
Telemetry [candidate] (15.775 ms) : 0, 15775
Flare Poller [baseline] (4.181 ms) : 0, 4181
Flare Poller [candidate] (4.173 ms) : 0, 4173
ProfilingAgent [baseline] (107.472 ms) : 0, 107472
ProfilingAgent [candidate] (107.45 ms) : 0, 107450
Profiling [baseline] (108.588 ms) : 0, 108588
Profiling [candidate] (108.906 ms) : 0, 108906
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~9bec9664b7, baseline=1.55.0-SNAPSHOT~1cd237641d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024440
Total [baseline] (8.662 s) : 0, 8661779
Agent [candidate] (1.018 s) : 0, 1017664
Total [candidate] (8.674 s) : 0, 8673684
section iast
Agent [baseline] (1.151 s) : 0, 1150581
Total [baseline] (9.234 s) : 0, 9233680
Agent [candidate] (1.158 s) : 0, 1157749
Total [candidate] (9.258 s) : 0, 9258074
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~9bec9664b7, baseline=1.55.0-SNAPSHOT~1cd237641d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (698.162 ms) : 0, 698162
BytebuddyAgent [candidate] (694.68 ms) : 0, 694680
GlobalTracer [baseline] (243.193 ms) : 0, 243193
GlobalTracer [candidate] (241.946 ms) : 0, 241946
AppSec [baseline] (32.991 ms) : 0, 32991
AppSec [candidate] (32.752 ms) : 0, 32752
Debugger [baseline] (6.445 ms) : 0, 6445
Debugger [candidate] (6.416 ms) : 0, 6416
Remote Config [baseline] (705.992 µs) : 0, 706
Remote Config [candidate] (689.888 µs) : 0, 690
Telemetry [baseline] (9.335 ms) : 0, 9335
Telemetry [candidate] (9.315 ms) : 0, 9315
Flare Poller [baseline] (10.991 ms) : 0, 10991
Flare Poller [candidate] (9.444 ms) : 0, 9444
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (814.806 ms) : 0, 814806
BytebuddyAgent [candidate] (819.986 ms) : 0, 819986
GlobalTracer [baseline] (231.831 ms) : 0, 231831
GlobalTracer [candidate] (232.874 ms) : 0, 232874
IAST [baseline] (26.638 ms) : 0, 26638
IAST [candidate] (26.867 ms) : 0, 26867
AppSec [baseline] (35.29 ms) : 0, 35290
AppSec [candidate] (35.41 ms) : 0, 35410
Debugger [baseline] (6.073 ms) : 0, 6073
Debugger [candidate] (6.213 ms) : 0, 6213
Remote Config [baseline] (612.646 µs) : 0, 613
Remote Config [candidate] (603.634 µs) : 0, 604
Telemetry [baseline] (8.549 ms) : 0, 8549
Telemetry [candidate] (8.781 ms) : 0, 8781
Flare Poller [baseline] (4.193 ms) : 0, 4193
Flare Poller [candidate] (4.209 ms) : 0, 4209
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9bec9664b7, baseline=1.55.0-SNAPSHOT~1cd237641d
dateFormat X
axisFormat %s
section baseline
no_agent (4.321 ms) : 4269, 4372
. : milestone, 4321,
iast (9.481 ms) : 9326, 9636
. : milestone, 9481,
iast_FULL (13.946 ms) : 13668, 14225
. : milestone, 13946,
iast_GLOBAL (10.822 ms) : 10628, 11016
. : milestone, 10822,
profiling (8.917 ms) : 8777, 9057
. : milestone, 8917,
tracing (7.714 ms) : 7600, 7828
. : milestone, 7714,
section candidate
no_agent (4.3 ms) : 4249, 4350
. : milestone, 4300,
iast (9.66 ms) : 9496, 9823
. : milestone, 9660,
iast_FULL (14.746 ms) : 14453, 15038
. : milestone, 14746,
iast_GLOBAL (10.237 ms) : 10054, 10420
. : milestone, 10237,
profiling (8.537 ms) : 8395, 8678
. : milestone, 8537,
tracing (7.798 ms) : 7688, 7909
. : milestone, 7798,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9bec9664b7, baseline=1.55.0-SNAPSHOT~1cd237641d
dateFormat X
axisFormat %s
section baseline
no_agent (37.475 ms) : 37174, 37777
. : milestone, 37475,
appsec (49.379 ms) : 48941, 49817
. : milestone, 49379,
code_origins (43.511 ms) : 43142, 43880
. : milestone, 43511,
iast (45.095 ms) : 44708, 45481
. : milestone, 45095,
profiling (49.238 ms) : 48751, 49724
. : milestone, 49238,
tracing (45.62 ms) : 45220, 46019
. : milestone, 45620,
section candidate
no_agent (37.478 ms) : 37167, 37790
. : milestone, 37478,
appsec (48.306 ms) : 47876, 48736
. : milestone, 48306,
code_origins (44.81 ms) : 44394, 45226
. : milestone, 44810,
iast (46.623 ms) : 46224, 47022
. : milestone, 46623,
profiling (47.252 ms) : 46831, 47673
. : milestone, 47252,
tracing (46.304 ms) : 45898, 46711
. : milestone, 46304,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9bec9664b7, baseline=1.55.0-SNAPSHOT~1cd237641d
dateFormat X
axisFormat %s
section baseline
no_agent (15.488 s) : 15488000, 15488000
. : milestone, 15488000,
appsec (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
iast (18.391 s) : 18391000, 18391000
. : milestone, 18391000,
iast_GLOBAL (17.691 s) : 17691000, 17691000
. : milestone, 17691000,
profiling (15.413 s) : 15413000, 15413000
. : milestone, 15413000,
tracing (15.162 s) : 15162000, 15162000
. : milestone, 15162000,
section candidate
no_agent (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
appsec (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
iast (18.367 s) : 18367000, 18367000
. : milestone, 18367000,
iast_GLOBAL (17.635 s) : 17635000, 17635000
. : milestone, 17635000,
profiling (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
tracing (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9bec9664b7, baseline=1.55.0-SNAPSHOT~1cd237641d
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.708 ms) : 3488, 3928
. : milestone, 3708,
iast (2.199 ms) : 2136, 2263
. : milestone, 2199,
iast_GLOBAL (2.242 ms) : 2178, 2306
. : milestone, 2242,
profiling (2.047 ms) : 1995, 2098
. : milestone, 2047,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
section candidate
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.725 ms) : 3506, 3944
. : milestone, 3725,
iast (2.205 ms) : 2141, 2268
. : milestone, 2205,
iast_GLOBAL (2.24 ms) : 2177, 2304
. : milestone, 2240,
profiling (2.066 ms) : 2013, 2119
. : milestone, 2066,
tracing (2.03 ms) : 1980, 2080
. : milestone, 2030,
|
What Does This Do
Allows the telemetry intake to recognise properly as a crash
origin
header field set tocrashtracker
is_crash
set totrue
to each Log entryMotivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]